Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:79822 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 98098 invoked from network); 20 Dec 2014 15:51:06 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Dec 2014 15:51:06 -0000 Authentication-Results: pb1.pair.com header.from=ajf@ajf.me; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ajf@ajf.me; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.199 as permitted sender) X-PHP-List-Original-Sender: ajf@ajf.me X-Host-Fingerprint: 192.64.116.199 imap11-2.ox.privateemail.com Received: from [192.64.116.199] ([192.64.116.199:40278] helo=imap11-2.ox.privateemail.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id EA/A0-28274-7EA95945 for ; Sat, 20 Dec 2014 10:51:04 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.privateemail.com (Postfix) with ESMTP id 298EB8800E6 for ; Sat, 20 Dec 2014 10:51:01 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at imap11.ox.privateemail.com Received: from mail.privateemail.com ([127.0.0.1]) by localhost (imap11.ox.privateemail.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id xNES8-LeZ2qX for ; Sat, 20 Dec 2014 10:51:01 -0500 (EST) Received: from oa-res-26-240.wireless.abdn.ac.uk (oa-res-26-240.wireless.abdn.ac.uk [137.50.26.240]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.privateemail.com (Postfix) with ESMTPSA id C4EC58800E2 for ; Sat, 20 Dec 2014 10:51:00 -0500 (EST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) In-Reply-To: <2F9B99EF-538C-4225-95A4-943F57DADF69@ajf.me> Date: Sat, 20 Dec 2014 15:50:58 +0000 Content-Transfer-Encoding: quoted-printable Message-ID: <97FF25C5-E881-4E53-A86A-3688BEE031FD@ajf.me> References: <2F9B99EF-538C-4225-95A4-943F57DADF69@ajf.me> To: internals X-Mailer: Apple Mail (2.1993) Subject: Re: [PATCH] Consistent type names in error messages From: ajf@ajf.me (Andrea Faulds) > On 14 Dec 2014, at 18:35, Andrea Faulds wrote: >=20 > I=E2=80=99ve made a patch which makes zend_parse_parameters and = userland type hints consistently show =E2=80=9Cinteger=E2=80=9D and = =E2=80=9Cfloat=E2=80=9D rather than =E2=80=9Clong=E2=80=9D and = =E2=80=9Cdouble=E2=80=9D: https://github.com/php/php-src/pull/955 >=20 > I also wrote a GNU sed script which I used to update the tests: = https://gist.github.com/TazeTSchnitzel/c0d780466def9f226318 Hi, Is anyone here opposed to this, or should I just merge it? I don=E2=80=99t= think it really needs an RFC. It doesn=E2=80=99t break BC. Thanks. -- Andrea Faulds http://ajf.me/