Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79701
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.180 as permitted sender)
Message-ID: <548FF210.4070903@gmail.com>
Date: Tue, 16 Dec 2014 00:49:20 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Sara Golemon <pollita@php.net>, 
 PHP internals <internals@lists.php.net>
References: <CAESVnVpkEmCxL-hApFX=iidA+J3Aejw7ryDs1FjomUSkymQpNA@mail.gmail.com> <CAESVnVpWxBROPzeNrmZoFGHQ0nJXLYv02N5TK8ai7e4X9vCVwA@mail.gmail.com>
In-Reply-To: <CAESVnVpWxBROPzeNrmZoFGHQ0nJXLYv02N5TK8ai7e4X9vCVwA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: [RFC] IntlChar class and intl_char_*() functions
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> Full implementation available now at
> https://github.com/sgolemon/php-src/compare/intl.uchar
> RFC updated to remove the functional API and clarify some things based
> on what I learned while implementing.

Thanks for your work! I think it may be good to make it a pull, since
it'd be easier to comment on that (and also Travis can say its word of
course :)

> Pay special attention to the #notes section regarding $limit which I
> think is a somewhat non-PHP API.

It says "some methods" but I found just one which is user-callable -
enumCharNames - and one that consumes callback with the same setup -
enumCharTypes - in the latter case I don't think it makes sense to
change anything since it's a callback for ICU. So, if I didn't miss
anything, it's one function and at that one that has matching callback
in ICU API. So I think it's best to leave it as is, especially that PHP
doesn't have the concept of ranges as such...
-- 
Stas Malyshev
smalyshev@gmail.com