Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79641
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 74.125.82.53 as permitted sender)
Content-Type: multipart/alternative; boundary="Apple-Mail=_E377134D-D9DD-4696-9E6A-0F9D91F1C2F1"
Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\))
In-Reply-To: <CAEKnhAHnqV2vkH+zNQCeyLrCSBSwOWm4GUX0DB5+AE_iu5Z84w@mail.gmail.com>
Date: Sun, 14 Dec 2014 20:46:32 +0100
Cc: Remi Collet <remi@fedoraproject.org>,
 PHP Internals <internals@lists.php.net>
Message-ID: <9B12C735-D384-42B1-9AE8-7E649D8C0F66@googlemail.com>
References: <543A1CB9.9040205@fedoraproject.org> <CAEKnhAFE6XFCJ6LZ3sZVtodrgM75xsqRPV2=M6KKb1aCep=oQw@mail.gmail.com> <5487EB7C.7040708@fedoraproject.org> <CAEKnhAHnqV2vkH+zNQCeyLrCSBSwOWm4GUX0DB5+AE_iu5Z84w@mail.gmail.com>
To: Jakub Zelenka <bukka@php.net>
Subject: Re: [PHP-DEV] PHP 7 and json
From: ingwie2000@googlemail.com ("Kevin Ingwersen (Ingwie Phoenix)")

--Apple-Mail=_E377134D-D9DD-4696-9E6A-0F9D91F1C2F1
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

I don=E2=80=99t know if you are interested in some other open source =
projects that parse JSON, but have you looked at the decoder here?

https://github.com/vstakhov/libucl <https://github.com/vstakhov/libucl>

It can parse more than just the JSON format - but it has some JSON =
benchmarks attached and works really well - and is plain C.
> Am 14.12.2014 um 20:38 schrieb Jakub Zelenka <bukka@php.net>:
>=20
> Hi,
>=20
> On Wed, Dec 10, 2014 at 6:43 AM, Remi Collet <remi@fedoraproject.org> =
wrote:
>>=20
>>=20
>> The main issue is the "non-free" decoder.
>>=20
>>=20
> Agreed.
>=20
>=20
>> Of course perf can be considered as an issue (I think minor).
>> jsonc have bad perf, but is free.
>>=20
>> If jsond have nearly same perf than old one, it's enough.
>=20
>=20
> My initial benchmarks (for PHP5 jsond ext) actually shows better
> performance for json instances containing strings. Pure int and floats =
are
> more or less the same. But need more benchmarks to confirm that.
>=20
>=20
>>> Just a quick update on jsond. The decoder is mostly done.
>>=20
>> So, please go on
>=20
>=20
> I have ported a decoder to PHP 7. The code can be found on my github
> php-src jsond branch ( for code changes see
> https://github.com/bukka/php-src/compare/jsond ). It's just a replaced
> decoder. The encoder is the same though. All tests are passing for =
me... I
> haven't done any perf tests as yet. There is a big room for =
improvements
> but it's a good start IMHO.
>=20
> I'll have more time during Christmas so I would like to improve the =
code
> and do some benchmarks. Think we could have RFC around New Year...
>=20
>=20
>>=20
>>> I have been recently working on optimization for the encoder. I
>>> already have over 30% speed improvement in encoding for string
>>> based arrays/objects like $_SERVER. It's generally much faster now
>>> but there is still a big room for other impromevents. I also
>>> experiment with a new buffer (replacement for smart_str in json
>>> encoder). It needs lots of optimization but it already gives better
>>> numbers for some cases. However it also gives worse numbers for
>>> some other cases like processing small integers so I need to play
>>> with it a bit more. As I said before I need a better set of
>>> benchmarks to be sure that it works fine for a big number of json
>>> instances.
>>=20
>> Current encoder is not an issue.
>> Perf. can be manage later.
>>=20
>> And I don't think we should use another string management for json
>> encoder, so if improvment is possible, should go in smart_str.
>>=20
>>=20
> Yeah I won't go there (replacing smart_str). It's still experimental =
and it
> would delay the whole thing quite a lot. I'll rather add just few =
proven
> improvements that are already done in jsond and that are not breaking =
ABI.
>=20
> Cheers
>=20
> Jakub


--Apple-Mail=_E377134D-D9DD-4696-9E6A-0F9D91F1C2F1--