Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79638
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.182 as permitted sender)
MIME-Version: 1.0
Sender: kalle.php@gmail.com
In-Reply-To: <2F9B99EF-538C-4225-95A4-943F57DADF69@ajf.me>
References: <2F9B99EF-538C-4225-95A4-943F57DADF69@ajf.me>
Date: Sun, 14 Dec 2014 19:41:39 +0100
Message-ID: <CAJW__o1v6QTwGXhgt4oXCYSubVa5Tu-zvMP-Dw1YCZ+RDSEsUQ@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [PATCH] Consistent type names in error messages
From: kalle@php.net (Kalle Sommer Nielsen)

2014-12-14 19:35 GMT+01:00 Andrea Faulds <ajf@ajf.me>:
> Good evening,
>
> Unfortunately, zend_parse_parameters and userland type hint error message=
s use outdated type names, and don=E2=80=99t even do so consistently. For e=
xample:
>
> $ php -r 'fread(0, 0);'
> PHP Warning:  fread() expects parameter 1 to be resource, integer given i=
n Command line code on line 1
>
> $ php -r 'fread(fopen("data:text/plain,test", "r"), fopen("data:text/plai=
n,test", "r"));'
> PHP Warning:  fread() expects parameter 2 to be long, resource given in C=
ommand line code on line 1
>
> $ php -r 'function foo(foobar $x) {} foo(1.0);'
> PHP Catchable fatal error:  Argument 1 passed to foo() must be an instanc=
e of foobar, double given, called in Command line code on line 1 and define=
d in Command line code on line 1
>
> Specifically, zend_parse_parameters will always =E2=80=9Cexpect=E2=80=9D =
a =E2=80=9Clong=E2=80=9D, yet when the expected type isn=E2=80=99t an integ=
er and an integer is passed, it says =E2=80=9Cinteger given=E2=80=9D. Along=
side this, both userland type hint errors and zend_parse_parameters errors =
refer to =E2=80=9Cdouble=E2=80=9D and not =E2=80=9Cfloat=E2=80=9D.
>
> I want to change the type names to be consistent, because I think our cur=
rent inconsistency is confusing. Integers are sometimes ints or integers, b=
ut other times longs. Floats are sometimes floats, but other times doubles.=
 If scalar type hints are ever added, then jettisoning the old aliases mean=
s we don=E2=80=99t have to add extra reserved words.
>

You forgot that they can also be 'real', but on a serious manner, I
don't see any reason not to make the error messages consistent and I
would say go ahead already.



--=20
regards,

Kalle Sommer Nielsen
kalle@php.net