Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79524
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.216 as permitted sender)
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\))
In-Reply-To: <548714D0.2010003@gmail.com>
Date: Wed, 10 Dec 2014 16:04:36 +0000
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <2C28A252-4E07-4AB9-BDEC-5BB9DD7CA8F3@ajf.me>
References: <24634FCA-EB3E-4805-A6D6-A1587A56C141@ajf.me> <42CB63B7-BB58-4A48-A738-08EF73D4395B@ajf.me> <CABBJUpcsUFHcGirT_ROqG7J8=+ii3y-p4mZsoBYRO4NYgnGzGA@mail.gmail.com> <A6CE3187-6AA7-4CDD-9B23-A1C317BF2EA7@ajf.me> <CABBJUpdBk_Od=tFdVeBoUyd8RYWkjEYFJzyUouPF=+hNND7CEw@mail.gmail.com> <5486F7BF.4070907@gmail.com> <D7F959A6-F912-44A8-AE3E-0B1C5159DAF9@ajf.me> <548714D0.2010003@gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Subject: Re: [PHP-DEV] [VOTE][RFC] ZPP Failure on Overflow
From: ajf@ajf.me (Andrea Faulds)


> On 9 Dec 2014, at 15:27, Rowan Collins <rowan.collins@gmail.com> =
wrote:
>=20
> Andrea Faulds wrote on 09/12/2014 14:10:
>>> On 9 Dec 2014, at 13:23, Rowan Collins <rowan.collins@gmail.com> =
wrote:
>>>=20
>>> Note that in master, the messages have been changed to (correctly) =
not mention the C types, only the PHP ones, so it would be more like =
"expects parameter 1 to be integer, float (which is beyond integer =
range) given".
>> They... have? When did this happen? It's something I was very much in =
favour of and wanted to do myself, but I was unaware this had recently =
changed. Does that mean I'll have to redo the patch for this RFC? :(
>>=20
>=20
> Oh; maybe not. I'm confused now.
>=20
> There's a commit making the change, I think in amongst the "64-bit" =
work: =
https://github.com/php/php-src/commit/63ea29a2067ce06e20dda861480d91624389=
f0f3
>=20
> But then the current master seems to be back using the old wording =
(random example): =
https://github.com/php/php-src/blob/master/ext/curl/tests/curl_setopt_erro=
r.phpt (Also, lxr.php.net doesn't show the PHPT files at all? =
http://lxr.php.net/xref/PHP_TRUNK/ext/curl/tests/)
>=20
> I actually prepared a PR a while ago to change everything, but master =
was a bit of a moving target at the time, so it probably needs a bit of =
work to rebase: https://github.com/php/php-src/pull/769 I didn't bother =
because I thought someone had beaten me to it, but maybe I should =
revisit it after all?

Hi!

It looks like those changes aren=92t in master. Once this RFC passes, =
I=92d very much like to see a new attempt to make the names consistent, =
it=92s something that=92s bothered me. If this was to be revisited, I =
think the names for IS_LONG and IS_BOOL should be =93int=94 and =93bool=94=
 respectively, not =93integer=94 and =93boolean=94, those feel more like =
proper type names. Also, it might be worth making is_long an alias of =
is_int, rather than the reverse which is what we have now.

Thanks!

--
Andrea Faulds
http://ajf.me/