Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79502
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.170 as permitted sender)
Message-ID: <548714D0.2010003@gmail.com>
Date: Tue, 09 Dec 2014 15:27:12 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: "internals@lists.php.net" <internals@lists.php.net>
References: <24634FCA-EB3E-4805-A6D6-A1587A56C141@ajf.me> <42CB63B7-BB58-4A48-A738-08EF73D4395B@ajf.me> <CABBJUpcsUFHcGirT_ROqG7J8=+ii3y-p4mZsoBYRO4NYgnGzGA@mail.gmail.com> <A6CE3187-6AA7-4CDD-9B23-A1C317BF2EA7@ajf.me> <CABBJUpdBk_Od=tFdVeBoUyd8RYWkjEYFJzyUouPF=+hNND7CEw@mail.gmail.com> <5486F7BF.4070907@gmail.com> <D7F959A6-F912-44A8-AE3E-0B1C5159DAF9@ajf.me>
In-Reply-To: <D7F959A6-F912-44A8-AE3E-0B1C5159DAF9@ajf.me>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: [VOTE][RFC] ZPP Failure on Overflow
From: rowan.collins@gmail.com (Rowan Collins)

Andrea Faulds wrote on 09/12/2014 14:10:
>> On 9 Dec 2014, at 13:23, Rowan Collins <rowan.collins@gmail.com> wrote:
>>
>> Xinchen Hui wrote on 09/12/2014 03:39:
>>> but I suggest change it to "expects parameter 1 to be long,
>>> double(which is beyond long range) given in %s on line %d"
>> Note that in master, the messages have been changed to (correctly) not mention the C types, only the PHP ones, so it would be more like "expects parameter 1 to be integer, float (which is beyond integer range) given".
> They... have? When did this happen? It's something I was very much in favour of and wanted to do myself, but I was unaware this had recently changed. Does that mean I'll have to redo the patch for this RFC? :(
>

Oh; maybe not. I'm confused now.

There's a commit making the change, I think in amongst the "64-bit" 
work: 
https://github.com/php/php-src/commit/63ea29a2067ce06e20dda861480d91624389f0f3

But then the current master seems to be back using the old wording 
(random example): 
https://github.com/php/php-src/blob/master/ext/curl/tests/curl_setopt_error.phpt 
(Also, lxr.php.net doesn't show the PHPT files at all? 
http://lxr.php.net/xref/PHP_TRUNK/ext/curl/tests/)

I actually prepared a PR a while ago to change everything, but master 
was a bit of a moving target at the time, so it probably needs a bit of 
work to rebase: https://github.com/php/php-src/pull/769 I didn't bother 
because I thought someone had beaten me to it, but maybe I should 
revisit it after all?

-- 
Rowan Collins
[IMSoP]