Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:79499 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 86945 invoked from network); 9 Dec 2014 14:10:29 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Dec 2014 14:10:29 -0000 Authentication-Results: pb1.pair.com header.from=ajf@ajf.me; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ajf@ajf.me; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ajf.me designates 198.187.29.245 as permitted sender) X-PHP-List-Original-Sender: ajf@ajf.me X-Host-Fingerprint: 198.187.29.245 imap11-3.ox.privateemail.com Received: from [198.187.29.245] ([198.187.29.245:35914] helo=imap11-3.ox.privateemail.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 10/06-39368-5D207845 for ; Tue, 09 Dec 2014 09:10:29 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.privateemail.com (Postfix) with ESMTP id 0AB0F8800DA; Tue, 9 Dec 2014 09:10:27 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at imap11.ox.privateemail.com Received: from mail.privateemail.com ([127.0.0.1]) by localhost (imap11.ox.privateemail.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id bZ8jUFvQDFp4; Tue, 9 Dec 2014 09:10:26 -0500 (EST) Received: from [137.50.28.227] (oa-res-28-227.wireless.abdn.ac.uk [137.50.28.227]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.privateemail.com (Postfix) with ESMTPSA id B4B608800DB; Tue, 9 Dec 2014 09:10:26 -0500 (EST) References: <24634FCA-EB3E-4805-A6D6-A1587A56C141@ajf.me> <42CB63B7-BB58-4A48-A738-08EF73D4395B@ajf.me> <5486F7BF.4070907@gmail.com> Mime-Version: 1.0 (1.0) In-Reply-To: <5486F7BF.4070907@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-ID: Cc: "internals@lists.php.net" X-Mailer: iPhone Mail (12B435) Date: Tue, 9 Dec 2014 14:10:22 +0000 To: Rowan Collins Subject: Re: [PHP-DEV] Re: [VOTE][RFC] ZPP Failure on Overflow From: ajf@ajf.me (Andrea Faulds) > On 9 Dec 2014, at 13:23, Rowan Collins wrote: >=20 > Xinchen Hui wrote on 09/12/2014 03:39: >> but I suggest change it to "expects parameter 1 to be long, >> double(which is beyond long range) given in %s on line %d" >=20 > Note that in master, the messages have been changed to (correctly) not men= tion the C types, only the PHP ones, so it would be more like "expects param= eter 1 to be integer, float (which is beyond integer range) given". They... have? When did this happen? It's something I was very much in favour= of and wanted to do myself, but I was unaware this had recently changed. Do= es that mean I'll have to redo the patch for this RFC? :( -- Andrea Faulds http://ajf.me/