Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:79494 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 77242 invoked from network); 9 Dec 2014 13:04:10 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Dec 2014 13:04:10 -0000 Authentication-Results: pb1.pair.com header.from=ajf@ajf.me; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ajf@ajf.me; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.207 as permitted sender) X-PHP-List-Original-Sender: ajf@ajf.me X-Host-Fingerprint: 192.64.116.207 imap2-2.ox.privateemail.com Received: from [192.64.116.207] ([192.64.116.207:36287] helo=imap2-2.ox.privateemail.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 7F/14-39368-943F6845 for ; Tue, 09 Dec 2014 08:04:09 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.privateemail.com (Postfix) with ESMTP id 66DF78C0085; Tue, 9 Dec 2014 08:04:06 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at imap2.ox.privateemail.com Received: from mail.privateemail.com ([127.0.0.1]) by localhost (imap2.ox.privateemail.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ag0EyEk3Utj6; Tue, 9 Dec 2014 08:04:06 -0500 (EST) Received: from [137.50.28.227] (oa-res-28-227.wireless.abdn.ac.uk [137.50.28.227]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.privateemail.com (Postfix) with ESMTPSA id C02068C0081; Tue, 9 Dec 2014 08:04:03 -0500 (EST) References: <24634FCA-EB3E-4805-A6D6-A1587A56C141@ajf.me> <42CB63B7-BB58-4A48-A738-08EF73D4395B@ajf.me> Mime-Version: 1.0 (1.0) In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-ID: Cc: internals X-Mailer: iPhone Mail (12B435) Date: Tue, 9 Dec 2014 13:04:00 +0000 To: Xinchen Hui Subject: Re: [PHP-DEV] Re: [VOTE][RFC] ZPP Failure on Overflow From: ajf@ajf.me (Andrea Faulds) Hi! > On 9 Dec 2014, at 03:39, Xinchen Hui wrote: >=20 > Hey: > that will confuse people, why 12.2 is okey (it's also a double value). >=20 > anyway, I am not a native english speaker, not sure what is the most > proper warning message. >=20 > but I suggest change it to "expects parameter 1 to be long, > double(which is beyond long range) given in %s on line %d" >=20 > what do you think? I realise the behaviour is somewhat confusing, but we also do this for other= parameter parsing failures and I don't have the time to go through and chan= ge all the tests again, unfortunately. I'd also need to change how error mes= sages are produced for fast parameter parsing. Thanks. -- Andrea Faulds http://ajf.me/