Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79489
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.215.52 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <A6CE3187-6AA7-4CDD-9B23-A1C317BF2EA7@ajf.me>
References: <24634FCA-EB3E-4805-A6D6-A1587A56C141@ajf.me> <42CB63B7-BB58-4A48-A738-08EF73D4395B@ajf.me>
 <CABBJUpcsUFHcGirT_ROqG7J8=+ii3y-p4mZsoBYRO4NYgnGzGA@mail.gmail.com> <A6CE3187-6AA7-4CDD-9B23-A1C317BF2EA7@ajf.me>
Date: Tue, 9 Dec 2014 11:39:43 +0800
Message-ID: <CABBJUpdBk_Od=tFdVeBoUyd8RYWkjEYFJzyUouPF=+hNND7CEw@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: [VOTE][RFC] ZPP Failure on Overflow
From: laruence@php.net (Xinchen Hui)

Hey:

On Mon, Dec 8, 2014 at 7:15 PM, Andrea Faulds <ajf@ajf.me> wrote:
>
>> On 8 Dec 2014, at 08:22, Xinchen Hui <laruence@php.net> wrote:
>
>> the current warning message is :" expects parameter 1 to be long,
>> double given in %s on line %d"
>>
>> but maybe it should be something like: "expects parameter 1 to be
>> long, double(which is beyond long range) given in %s on line %d"?
>>
>> since it's not the fault of double self, right?
>
> Hi Xinchen,
>
> I had thought of doing that, although for all other failures we also don'=
t give  special error messages. I don't have the time to go through and upd=
ate every single test again, though. I initially did have an error message =
that showed the range that the float needs to have, but this was a problem =
because it means the error message might vary by platform (pain to test)
that will confuse people, why 12.2 is okey (it's also a double value).

anyway, I am not a native english speaker, not sure what is the most
proper warning message.

but I suggest change it to "expects parameter 1 to be long,
double(which is beyond long range) given in %s on line %d"

what do you think?

thanks
>
> --
> Andrea Faulds
> http://ajf.me/



--=20
Xinchen Hui
@Laruence
http://www.laruence.com/