Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:79479 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 2552 invoked from network); 8 Dec 2014 19:42:51 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Dec 2014 19:42:51 -0000 Authentication-Results: pb1.pair.com smtp.mail=keisial@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=keisial@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.177 as permitted sender) X-PHP-List-Original-Sender: keisial@gmail.com X-Host-Fingerprint: 209.85.212.177 mail-wi0-f177.google.com Received: from [209.85.212.177] ([209.85.212.177:61827] helo=mail-wi0-f177.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DB/A6-62069-A3FF5845 for ; Mon, 08 Dec 2014 14:42:50 -0500 Received: by mail-wi0-f177.google.com with SMTP id l15so5834734wiw.16 for ; Mon, 08 Dec 2014 11:42:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=nA2ANzSpd6GpkVtJp0sWq8pVG3K5+9SjQ8xE+LGnnsc=; b=OLKv3h6kAvT5//a8u4GDXP5WmeJprdBALdiZsD/Bck+YyegBqSiLET73y40DK/PMWt 2pd0dn8PoTDlhPIvrxqoAYWKWWdYv6xMk1z2s41VXM/1iPa9iMs14VKF9hcMzcFQC6US RZIY844fOkJY51cVFYNZEfsIdoVL5ioa19HkEcG09YbQoZnppzyuQl9hStKEI02R/38k ZmU0WhzWsJa/qcTZPkfYifYY10U6QrBoYQZtcEX0pT6EYWm2yyCpVtK1oh6SfS9RFeEh 2vlPTKWLh+Hy+9nQzeDiBrl74Ng9d8/2eSAnPeBeWsp/ZMwNrTLYLrsNpOQrxyF8tip3 hbgg== X-Received: by 10.180.104.65 with SMTP id gc1mr26121411wib.46.1418067766944; Mon, 08 Dec 2014 11:42:46 -0800 (PST) Received: from [192.168.1.27] (184.Red-88-23-225.staticIP.rima-tde.net. [88.23.225.184]) by mx.google.com with ESMTPSA id cq4sm57799036wjc.35.2014.12.08.11.42.45 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 08 Dec 2014 11:42:45 -0800 (PST) Message-ID: <5485FF34.1050305@gmail.com> Date: Mon, 08 Dec 2014 20:42:44 +0100 User-Agent: Thunderbird MIME-Version: 1.0 To: internals@lists.php.net References: <790a8d7299a7cda01ee76d8293b7d5af.squirrel@webmail.klapt.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [RFC] Native TLS From: keisial@gmail.com (=?UTF-8?B?w4FuZ2VsIEdvbnrDoWxleg==?=) On 03/12/14 10:22, Anatol Belski wrote: > I meant that as well, to the time it's merged all the TSRMLS_* thingies > should be removed. I kept them only while developed and now for the RFC so > the diff shows the only change done, otherwise it would sink in the > unrelevant stuff. > > Therefore I'd rather stay by the yes/no choice as removing TSRMLS_* is the > essential part of the RFC - so better at once then :) As otherwise one can > sure find some factor to defer the actual change, but the change is the > actual goal. > > Regards > > Anatol It seems quite clear to me: 1. Change the code. 2. Remove the TSRMLS_* macros from the code in a subsequent commit 3. Leave the no-op macros at an unused header for a few releases, for the benefit of porting extensions / extensions targetting several versions.