Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79445
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.181 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <CABBJUpe+KBJfX1JZXFTwzKrCqGsGe4x06OGHa_NLppBQpYdmzg@mail.gmail.com>
References: <CAFMT4Nq19=5UKqGdCh=w9LbgTo25fUpY1MNNHVi=ND+oto=xsg@mail.gmail.com>
	<CABBJUpe+KBJfX1JZXFTwzKrCqGsGe4x06OGHa_NLppBQpYdmzg@mail.gmail.com>
Date: Fri, 5 Dec 2014 08:00:56 -0700
Message-ID: <CAFMT4Npy-TLPmTWrg3_F-Uc3kJnh6udLcfs0yJsYAm_2npCYqg@mail.gmail.com>
To: Xinchen Hui <laruence@php.net>
Cc: internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Two small const correctness changes
From: levim@php.net (Levi Morrison)

On Thu, Dec 4, 2014 at 9:11 PM, Xinchen Hui <laruence@php.net> wrote:
> Hey:
>
> On Fri, Dec 5, 2014 at 8:08 AM, Levi Morrison <levim@php.net> wrote:
>> These changes make ZVAL_COPY and ZVAL_COPY_VALUE work without warning
>> for places where the zval that is copied is const:
>> https://gist.github.com/morrisonlevi/69156fdf93e6bc82f9a0
>>
>> In the default build there do not seem to be any places where this
>> causes a warning, but I noticed it in an extension I'm writing. I do
>> not yet have Zend Engine karma; hence posting to the list.
> done.
>
> thanks

Thank you for committing this.