Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79433
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.216 as permitted sender)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\))
In-Reply-To: <CAJW__o33jiiUkp9MhReSTJ61Q_P=0MkjsmK9J1tPy=kQe+7=3A@mail.gmail.com>
Date: Thu, 4 Dec 2014 23:18:50 +0000
Cc: Yasuo Ohgaki <yohgaki@ohgaki.net>,
 "internals@lists.php.net" <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <58DB03A5-37B2-4244-BC4F-478DEAEC1153@ajf.me>
References: <CAGa2bXaAqbV4OnJSnXNboaZXD7cROR+Ue8jCE33uKci7kNo-KA@mail.gmail.com> <CAJW__o33jiiUkp9MhReSTJ61Q_P=0MkjsmK9J1tPy=kQe+7=3A@mail.gmail.com>
To: Kalle Sommer Nielsen <kalle@php.net>
Subject: Re: [PHP-DEV] Only variables can be passed by reference
From: ajf@ajf.me (Andrea Faulds)


> On 4 Dec 2014, at 19:58, Kalle Sommer Nielsen <kalle@php.net> wrote:
>=20
> I think we should solve these on a case-by-case basis, I can think of
> one reason why the warning exists, and that is because it modifies the
> array pointer and the argument is sent by reference. But I think we
> can safely remove the warning if the parameter was not sent by
> reference, as then we would expect the user to use the return value of
> array_pop() to assign the value from. I don't think we should remove
> warnings if you pass a statically value to it, sure some APIs can
> return a variable length/dynamic array but then I think they should be
> referenced into a variable and then passed to the function as they are
> most likely going to be used later, I can't really think of a case
> where it would be useful to send a return value of some API call to
> array_multisort() and then use the boolean true or false to check if
> it was a successful call for example..

Doing it case-by-case seems like the most pragmatic approach.

That being said, I=E2=80=99m not sure there are many cases, if any, for =
which I don=E2=80=99t think a warning should be shown. It feels like an =
abuse of the internal array pointer functions =
(next/prev/key/extract/etc.) to use them like this. It=E2=80=99d =
probably be better to add non-by-ref functions that do the same thing =
instead.

--
Andrea Faulds
http://ajf.me/