Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79422
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.49 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAMUwpuTMgG=hJY4qVdst9zVgDTS7Y3QxSBFT80eBC_xSbWZFtA@mail.gmail.com>
References: <CAEPJdu=uW9D4Bz7hDhiGt=_qvWhAJfNfFwBJ0BKD77-L9rkgwQ@mail.gmail.com>
	<CAMUwpuTMgG=hJY4qVdst9zVgDTS7Y3QxSBFT80eBC_xSbWZFtA@mail.gmail.com>
Date: Thu, 4 Dec 2014 12:39:39 +0100
Message-ID: <CAH-PCH5v-AyEiBRwZ=FCPkPk1GtyJEdk8k6FzFLRfZHbhuYbAg@mail.gmail.com>
To: Julien Pauli <jpauli@php.net>
Cc: Benjamin Eberlei <kontakt@beberlei.de>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e011779f55f3f460509626a73
Subject: Re: [PHP-DEV] [RFC] Turn gc_collect_cycles into a function pointer
From: tyra3l@gmail.com (Ferenc Kovacs)

--089e011779f55f3f460509626a73
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 4, 2014 at 11:53 AM, Julien Pauli <jpauli@php.net> wrote:

> On Thu, Dec 4, 2014 at 9:30 AM, Benjamin Eberlei <kontakt@beberlei.de>
> wrote:
> > Good morning,
> >
> > This is just a very small change, I propose this RFC for discussion to
> turn
> > the C function "gc_collect_cycles" into a pointer.
> >
> > https://wiki.php.net/rfc/gc_fn_pointer
> >
> > Composer's garbage collection optimization showed that PHP Profilers fa=
il
> > to capture the dynamics of GC and we need better hooks to make this
> > possible.
>
> There are many other things that could be turned into function
> pointers to allow extensions to hook.
> Our hook strategy should be reviewed entirely.
>
> Not only GC. If you look at streams, many of them are not
> overwritable, and some are, but they are missing from the headers file
> so you may not overwrite them.
>
> I suggest we design a wider RFC for PHP7 about what we would be able
> to hook, and what not (and what is the impact, because the more you
> hook , the more complex it becomes about bad interactions).
>
> This may also include a refactoring in the zend_module_entry and the
> zend_extension structs. Fe, zend_extension hooks about the op_array
> could be reworked , I find the op_array_dtor_handler hook misplaced in
> the chain.
> zend_module_entry could also benefit from refactoring to have a better
> knowing of other extensions, and a true dependency manager.
>
>
That sounds like a lot of work.
+1 if somebody willing to champion that effort, but I wouldn't
delay/discard this small improvement on the vague promise that maybe this
will be solved as part of a bigger rfc.
just my 2 cents ofc.

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--089e011779f55f3f460509626a73--