Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:79411 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 14154 invoked from network); 4 Dec 2014 05:57:53 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Dec 2014 05:57:53 -0000 Authentication-Results: pb1.pair.com smtp.mail=xinchen.h@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=laruence@php.net; sender-id=unknown Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.215.47 as permitted sender) X-PHP-List-Original-Sender: xinchen.h@zend.com X-Host-Fingerprint: 209.85.215.47 mail-la0-f47.google.com Received: from [209.85.215.47] ([209.85.215.47:36252] helo=mail-la0-f47.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4E/0C-15597-FD7FF745 for ; Thu, 04 Dec 2014 00:57:52 -0500 Received: by mail-la0-f47.google.com with SMTP id hz20so14055510lab.34 for ; Wed, 03 Dec 2014 21:57:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=PTdGqzeEW/nv/M7T3bN3EnHPeP+o4fwrUYwv6KtSkag=; b=ddEIAu6Kud7yLusIah/r4TD43kgZ7aiDfEElto1KwQGgsMh+9O552xP8/+dINjpADm K+WMubBgCPaEjtWeWQyhxReY7AnSdc9RahcTGBl0sJd3Dx6/Mz8KKfp7+I7Evk/l8pkq 3NtQQE7XzdNPevD2FfmcVM2XNprV8dRASVKF3p9yWeMp2rgLpQJpn2MiNHKW8nFyGl+m alQf3oH4656lcxnCMgQ6yjvLURNB83s6rDGBNQovniR+SxiAvMC53nzr3zN04ku3k998 6c9nkJCfY3T5qU8s3etv9/jfNbBCmHysyNZy7Ls1vaUPk+zCmtX5qZr0YS++G3q2yyB3 StZw== X-Gm-Message-State: ALoCoQn9fZFCCOoW+xBRGgPnRA8T/jZuV+CG205k7N95HISX5jqKBLRBMpv/qLTuuB1ydvfPqBi0tj8HZGV9JAnsL/W9wtiBevol8rNdiGUqJ/WN296vbKYHHy9gPcq/VAxbNuvmw8dFuWMkAL9uL8nLjiaGvyYF8w== X-Received: by 10.152.206.67 with SMTP id lm3mr7674208lac.16.1417672668718; Wed, 03 Dec 2014 21:57:48 -0800 (PST) Received: from mail-la0-f50.google.com (mail-la0-f50.google.com. [209.85.215.50]) by mx.google.com with ESMTPSA id kw10sm3362259lac.45.2014.12.03.21.57.47 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 03 Dec 2014 21:57:47 -0800 (PST) Received: by mail-la0-f50.google.com with SMTP id pn19so13178746lab.9 for ; Wed, 03 Dec 2014 21:57:47 -0800 (PST) X-Received: by 10.112.150.102 with SMTP id uh6mr7807785lbb.50.1417672667216; Wed, 03 Dec 2014 21:57:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.114.64.176 with HTTP; Wed, 3 Dec 2014 21:57:26 -0800 (PST) In-Reply-To: <1C1A4848-0E69-4197-AF75-2ED0A0AECD2A@ajf.me> References: <24634FCA-EB3E-4805-A6D6-A1587A56C141@ajf.me> <1C1A4848-0E69-4197-AF75-2ED0A0AECD2A@ajf.me> Date: Thu, 4 Dec 2014 13:57:26 +0800 Message-ID: To: Andrea Faulds Cc: internals Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] [VOTE][RFC] ZPP Failure on Overflow From: laruence@php.net (Xinchen Hui) On Thu, Dec 4, 2014 at 1:54 PM, Andrea Faulds wrote: > >> On 4 Dec 2014, at 05:51, Xinchen Hui wrote: >> >>> >> I am not sure if I misunderstand your proposal.. >> >> I thought you proposal is only fail if double value is out of long range >> >> but from your patch, ext/date/tests/date_sunset_variation9.phpt is >> fails with a double value 12.*** (which is obviously not out of long >> range). > > That one caught me out too! Look more carefully, I missed it the first ti= me. > > 12.3456789000e10 has a sneaky =E2=80=9Ce10=E2=80=9D at the end, so it=E2= =80=99s more like 123456789000 ;) Ah...... okey.... :) thanks > > -- > Andrea Faulds > http://ajf.me/ > > > > --=20 Xinchen Hui @Laruence http://www.laruence.com/