Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:79410 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 12710 invoked from network); 4 Dec 2014 05:54:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Dec 2014 05:54:50 -0000 Authentication-Results: pb1.pair.com smtp.mail=ajf@ajf.me; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=ajf@ajf.me; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.207 as permitted sender) X-PHP-List-Original-Sender: ajf@ajf.me X-Host-Fingerprint: 192.64.116.207 imap2-2.ox.privateemail.com Received: from [192.64.116.207] ([192.64.116.207:40953] helo=imap2-2.ox.privateemail.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B8/BB-15597-927FF745 for ; Thu, 04 Dec 2014 00:54:49 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.privateemail.com (Postfix) with ESMTP id 6E7998C0085; Thu, 4 Dec 2014 00:54:46 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at imap2.ox.privateemail.com Received: from mail.privateemail.com ([127.0.0.1]) by localhost (imap2.ox.privateemail.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 2S30kBvCCbqt; Thu, 4 Dec 2014 00:54:46 -0500 (EST) Received: from oa-res-27-210.wireless.abdn.ac.uk (oa-res-27-210.wireless.abdn.ac.uk [137.50.27.210]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.privateemail.com (Postfix) with ESMTPSA id 9AE768C0084; Thu, 4 Dec 2014 00:54:45 -0500 (EST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) In-Reply-To: Date: Thu, 4 Dec 2014 05:54:43 +0000 Cc: internals Content-Transfer-Encoding: quoted-printable Message-ID: <1C1A4848-0E69-4197-AF75-2ED0A0AECD2A@ajf.me> References: <24634FCA-EB3E-4805-A6D6-A1587A56C141@ajf.me> To: Xinchen Hui X-Mailer: Apple Mail (2.1993) Subject: Re: [PHP-DEV] [VOTE][RFC] ZPP Failure on Overflow From: ajf@ajf.me (Andrea Faulds) > On 4 Dec 2014, at 05:51, Xinchen Hui wrote: >=20 >>=20 > I am not sure if I misunderstand your proposal.. >=20 > I thought you proposal is only fail if double value is out of long = range >=20 > but from your patch, ext/date/tests/date_sunset_variation9.phpt is > fails with a double value 12.*** (which is obviously not out of long > range). That one caught me out too! Look more carefully, I missed it the first = time. 12.3456789000e10 has a sneaky =E2=80=9Ce10=E2=80=9D at the end, so = it=E2=80=99s more like 123456789000 ;) -- Andrea Faulds http://ajf.me/