Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79409
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.217.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <24634FCA-EB3E-4805-A6D6-A1587A56C141@ajf.me>
References: <24634FCA-EB3E-4805-A6D6-A1587A56C141@ajf.me>
Date: Thu, 4 Dec 2014 13:51:06 +0800
Message-ID: <CABBJUpccuN188xOOBgpV5+OUCm1Eg-SJQyw4odDf0af1j0QvCQ@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [VOTE][RFC] ZPP Failure on Overflow
From: laruence@php.net (Xinchen Hui)

Hey:

On Wed, Dec 3, 2014 at 5:44 AM, Andrea Faulds <ajf@ajf.me> wrote:
> Good evening once again,
>
> I=E2=80=99m putting the ZPP Failure on Overflow RFC to a vote. This RFC i=
s an important prerequisite to the Big Integer Support RFC, as it ensures s=
afety in implicit integer parameter conversions.
>
> The RFC requires a 2/3 majority, and voting starts today (2014-12-02) and=
 ends in 10 days=E2=80=99 time next Friday (2014-12-12).
>
> Please read the RFC carefully. If you have any doubts or queries about th=
e RFC, please don=E2=80=99t hesitate to ask me.
>
> The RFC and voting widget can be found here: https://wiki.php.net/rfc/zpp=
_fail_on_overflow
>
> Thanks!
I am not sure if I misunderstand your proposal..

I thought you proposal is only fail if double value is out of long range

but from your patch, ext/date/tests/date_sunset_variation9.phpt  is
fails with a double value 12.*** (which is obviously not out of long
range).

thanks
> --
> Andrea Faulds
> http://ajf.me/
>
>
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>



--=20
Xinchen Hui
@Laruence
http://www.laruence.com/