Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79408
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFMT4Npr-urz0hDHmn1E9JniURgjFD8fOKUGFf1zgpYR-+_O9w@mail.gmail.com>
References: <CAFp73Xtmw6PVxN0XaKkjJC5M5PU-W=prpYDob5aXHuQzE5dwNw@mail.gmail.com>
 <CAFMT4Npr-urz0hDHmn1E9JniURgjFD8fOKUGFf1zgpYR-+_O9w@mail.gmail.com>
Date: Wed, 3 Dec 2014 20:39:16 -0500
Message-ID: <CAFp73Xugd2novgpwGDruWU-p2K=8GZwKQ1mus=c6C6nZ1EzwqA@mail.gmail.com>
To: Levi Morrison <levim@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113ebbf86e9f1005095a08bd
Subject: Re: [PHP-DEV] Zend language parser improvements
From: guilhermeblanco@gmail.com ("guilhermeblanco@gmail.com")

--001a113ebbf86e9f1005095a08bd
Content-Type: text/plain; charset=UTF-8

On Wed, Dec 3, 2014 at 8:06 PM, Levi Morrison <levim@php.net> wrote:

> The parser changes need to be careful reviewed; I don't have time at
> the moment to verify it but I think you unintentionally allowed some
> syntax's that shouldn't be valid because of the addition to
> `inner_statement`.
>

Shouldn't. I broke down class_declaration_statement into 3 pieces:
class_declaration_statement, interface_declaration_statement and
trait_declaration_statement.
At the end, all I've done is adding the other 2 new rules back to where it
was consumed.


>
> Maybe I just looked too quickly. In any case, parser changes should
> always get several people reviewing them.
>

Agreed. =)

-- 
Guilherme Blanco
MSN: guilhermeblanco@hotmail.com
GTalk: guilhermeblanco
Toronto - ON/Canada

--001a113ebbf86e9f1005095a08bd--