Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79404
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.15.15 as permitted sender)
Message-ID: <547F8A29.6030000@gmx.de>
Date: Wed, 03 Dec 2014 23:09:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Peter Cowburn <petercowburn@gmail.com>
CC: internals@lists.php.net
References: <547F741D.6030507@gmx.de> <CAPg3Xx+z=2U_O7-Tn6Hv9t2+7qLNQUcA6r80=-7ZHooc3bXb-g@mail.gmail.com>
In-Reply-To: <CAPg3Xx+z=2U_O7-Tn6Hv9t2+7qLNQUcA6r80=-7ZHooc3bXb-g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Conversion of SplFileInfo instances to boolean
From: cmbecker69@gmx.de (Christoph Becker)

Peter Cowburn wrote:

> On 3 December 2014 at 20:35, Christoph Becker <cmbecker69@gmx.de> wrote:
> 
>> Hello internals,
>>
>> today I stumbled over issue #65213[1] which has been reported as a bug,
>> but was changed to a feature request without any hint why the conversion
>> of SplFileInfo instances to boolean throws a catchable fatal error.
>>
>> Even worse, due to optimizations in OPcache (and maybe other optimizers
>> as well), this does not always happen.  Consider the following snippet:
>>
>>     <?php
>>
>>     $o = new SplFileObject('.');
>>     if (!$o) {
>>     } else {
>>         var_dump(!$o);
>>     }
>>
>> Without any optimization this throws the error in line 4 (the if
>> clause); with OPcache the error is thrown in line 6.  Apparently that is
>> caused by a optimization where BOOL_NOT,JMPZ is converted to NOP,JMPNZ[2].
>>
>> IOW: with OPcache enabled `if (!$o)` works fine, but without OPcache it
>> is an error.  IMHO both should behave identically.
>>
>> [1] <https://bugs.php.net/bug.php?id=65213>
>>
> 
> This looks fixed in master (https://github.com/php/php-src/commit/8904f72
> <https://github.com/php/php-src/commit/8904f72d7c47253345f7039afd8ca754442c7e34>
> ).

Indeed, thanks.  <http://3v4l.org/1fHVC> confirms that.  However, if the
former behavior is regarded as a bug, shouldn't it be fixed for PHP 5.5
and PHP 5.6 as well?

Anyhow, the bug report/feature request might be closed.

-- 
Christoph M. Becker