Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79333
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAH-PCH65Gjs-Y3CupNJ7RPSvPSmoJubvneE9LeLVywYTk5RRug@mail.gmail.com>
References: <CA+9eiLuiLUoKRrR7_Mp2UmYKMpwqcUPQ+Kd8zixuLQ3TQv7CTg@mail.gmail.com>
	<CABBJUpd28ZS=Pqu2heUJR0X9PW=9S1Q42zXm5vqs8+XVQ_AYKA@mail.gmail.com>
	<CA+9eiLu3VafPkZ68M_Uk-PL_HJrzTqBCWtQ1-0UqPfSz8g2xFQ@mail.gmail.com>
	<CAH-PCH6jPJKbt4thmHHBUiVP5UaFqe4tSSPj22XFvT_Uke4QCQ@mail.gmail.com>
	<CA+9eiLvRUWAPc-v1W-9j1Ec5=-6jouYFcOjSF6CJkCV6f3e3nA@mail.gmail.com>
	<CAH-PCH65Gjs-Y3CupNJ7RPSvPSmoJubvneE9LeLVywYTk5RRug@mail.gmail.com>
Date: Mon, 1 Dec 2014 12:17:22 +0400
Message-ID: <CA+9eiLvxYeT8ZN-14FGhwF-w+MzKUhia8x9fK4dEj_2QhHdXGA@mail.gmail.com>
To: Ferenc Kovacs <tyra3l@gmail.com>
Cc: PHP Internals <internals@lists.php.net>, Matteo Beccati <matteo@beccati.com>, 
	Xinchen Hui <xinchen.h@zend.com>, Nikita Popov <nikita.ppv@gmail.com>
Content-Type: multipart/alternative; boundary=001a113659d06552f80509233d47
Subject: Re: [PHP-DEV] Re: EX(scope) removing
From: dmitry@zend.com (Dmitry Stogov)

--001a113659d06552f80509233d47
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

thanks.
phpdbg was excluded in my DEBUG build (I was sure I built it, may be it was
enabled it default previously...)
Anyway, I enabled it now, and won't miss at least build problems.

According to "make test", it would be great to make it run all the tests.
For some reason "ext/opcahce" tests are excluded as well.

Thanks. Dmitry.

On Sun, Nov 30, 2014 at 7:25 PM, Ferenc Kovacs <tyra3l@gmail.com> wrote:

>
> 2014.11.30. 11:14 ezt =C3=ADrta ("Dmitry Stogov" <dmitry@zend.com>):
> >
> > Sorry, I'll try to fix it on Monday.
> > is it a compilation problem, or how can reproduce it?
>
> I've fixed it already. There were two references to scope in phpdbg, you
> probably missed it because phpdbg tests are not part of make test (but
> could be).
>
> >
> > Thanks. Dmitry.
> >
> > On Sat, Nov 29, 2014 at 1:01 AM, Ferenc Kovacs <tyra3l@gmail.com> wrote=
:
> >>
> >> 2014.11.28. 9:24 ezt =C3=ADrta ("Dmitry Stogov" <dmitry@zend.com>):
> >>
> >>
> >> >
> >> > On Fri, Nov 28, 2014 at 7:33 AM, Xinchen Hui <xinchen.h@zend.com>
> wrote:
> >> >
> >> > > Hey:
> >> > >
> >> > > On Fri, Nov 28, 2014 at 1:27 AM, Dmitry Stogov <dmitry@zend.com>
> wrote:
> >> > > > Hi,
> >> > > >
> >> > > > I'm working on call/return sequence optimization. As part of thi=
s
> work
> >> > > I'm
> >> > > > minimizing the size of call frame (zend_execute_data) and number
> of
> >> > > > read/write operations on call/return.
> >> > > >
> >> > > > Could you please take a look into the patch that removes EX(scop=
e)
> >> > > > https://gist.github.com/dstogov/5ad50d582346385d587e
> >> > >
> >> >
> >> > committed.
> >> >
> >> > > All phpt tests are passed, but I'm not completely sure about one
> line -
> >> > > >
> >> > >
> https://gist.github.com/dstogov/5ad50d582346385d587e#file-ex_scope-05-dif=
f-L193
> >> > > >
> >> > > > On the other hand I can't imagine what it may break.
> >> > > neither do I.
> >> > >
> >> > > >
> >> > > > Matteo, can you please run your test suites with this patch.
> >> > > >
> >> > > > PS: I'm also going to:
> >> > > > - pack EX(num_args) into reserved space of EX(This)
> >> > >
> >> >
> >> > done.
> >> >
> >> >
> >> > > > - try to get rid of EX(frame_info)
> >> > >
> >> >
> >> > done.
> >> >
> >> >
> >> > > > - try to merge EX(called_scope) and EX(This). Only one of them
> matters.
> >> > > > - try to replace zval EX(This) with a pointer to zend_object
> EX(object)
> >> > >
> >> > > Hmm, EX(This) is not like EX(object), it will be accessed by vm
> >> > > handler: get_obj_zval_ptr_unused
> >> > >
> >> > > it suppores to return a zval * there. if EX(This) became a
> zend_object
> >> > > *, then we may face different handlers for  IS_UNUSED and other
> types
> >> > > :<
> >> > >
> >> >
> >> > Yes, I know. After the latest changes it doesn't make a lot of sense
> to
> >> > replace ZVAL with ZEND_OBJECT*, because other data is already packed
> into
> >> > the same ZVAL and it won't save any memory.
> >> >
> >> > Also zend_execute_data structure is aligned on zval boundary (16
> bytes), so
> >> > it makes sense to save another 16 bytes, but saving 8 bytes won't
> affect VM
> >> > stack memory consumption.
> >> >
> >> > Thanks. Dmitry.
> >> >
> >>
> >> Fyi this change broke phpdbg in master.
> >
> >
>

--001a113659d06552f80509233d47--