Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79310
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain a2o.si designates 78.47.12.76 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <5479038D.8070700@gmail.com>
References: <CAEp_DRDt21rChTmC506VxxF-RxHpPoMvUMAFhpXHCQSgCOcYHQ@mail.gmail.com>
	<5479038D.8070700@gmail.com>
Date: Sat, 29 Nov 2014 19:04:00 +0100
Message-ID: <CAEp_DRDd9EJ1vyE8aSPL789JSChUMrz8F7zbTTAspQDTK1ZZjQ@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] New function: spl_object_id() or spl_object_handle()
From: bostjan@a2o.si (Bostjan Skufca)

On 29 November 2014 at 00:21, Rowan Collins <rowan.collins@gmail.com> wrote:
> On 28/11/2014 01:13, Bostjan Skufca wrote:
>>
>> A function called spl_object_hash() exists,
>> but it returns identical hashes for equal objects.
>
> In case it's been lost in the noise, no it doesn't.

Ouch. I am terribly sorry about this mistake, it really does not.

However, having word "hash" in the function name suggests that
returned hash is generated by the object's contents, too. I just
noticed that the first comment explains that this is not the case,
which I confirmed with additional testing.

To quote a part of first sentence of Wikipedia on "Hash function":
"...with slight differences in input data producing very big
differences in output data."

So, to sum it up: spl_object_hash indeed does what I initially
required, but I was mislead by the "hash" word in its name, and the
environment where I was trying to use it (unable to bring two object
references in the same place easily).

But I would maybe suggest changing the name to spl_object_id (and
keeping ..._hash alias for backward compatibility).

b.