Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79286
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain acquia.com designates 64.18.2.206 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAH0thKAJ4FGwua9mP96dgmNx9qW_WSkb8hfBfQuSzyFFE77fBQ@mail.gmail.com>
References: <CAH0thKDOOV0DT5=DJRmoePXOtJhzJtwteTEW_iNA+5Q-gNXdxg@mail.gmail.com>
	<1415638978.23992.4.camel@kuechenschabe>
	<CAH0thKBjR-6g0yrDtSORO9PszDnoMUJ2v5wUBxMh8iDdVYQ=Sw@mail.gmail.com>
	<CAH0thKBHf1=XiHs20_1az2uaJ1=0AnWpC7unvAKYL1EK4shx3w@mail.gmail.com>
	<CAH-PCH70P2ZktJ0QPFycSB7X=9TFBQ9LBC3yZhrCnjwHuDczpA@mail.gmail.com>
	<CAH0thKAJ4FGwua9mP96dgmNx9qW_WSkb8hfBfQuSzyFFE77fBQ@mail.gmail.com>
Date: Fri, 28 Nov 2014 14:16:13 -0500
Message-ID: <CAH0thKCa__zuvT2uedicz8u1nRHPvT0up9AzE1+tMfakzX6ScQ@mail.gmail.com>
To: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] PDO mysql - add feature to enforce single statements?
From: peter.wolanin@acquia.com (Peter Wolanin)

>>> > On Mon, Nov 10, 2014 at 12:02 PM, Johannes Schl=C3=BCter <
>>> > johannes@schlueters.de> wrote:
>>> >
>>> >> On Thu, 2014-11-06 at 19:52 -0500, Peter Wolanin wrote:
>>> >> > Suggested solution: add a PDO attribute that could be set on a
>>> >> > connection or a driver option for PDO::prepare to enforce the limi=
t
>>> >> > of
>>> >> > a single query being prepared or run.
>>> >>
>>> >> The issue is that disabling multi-query implicitly also disables
>>> >> support
>>> >> for stored procedures as the same flag configures handling of
>>> >> operations
>>> >> with multiple result sets. So this probably needs more thoughts
>>> >> especially in order to get "similar" behavior with different
>>> >> databases ... can you add a feature request in the bug tracker for
>>> >> this?
>>> >>
>>> >> johannes
>>> >>


I've just added another test to address the concern from Johannes that
setting this flag would interfere with stored procedures.

It's a partial copy of the existing
ext/pdo_mysql/tests/pdo_mysql_stmt_nextrowset.phpt which has an
expected fail.

The new test uses just native prepare (which does not fail) and runs
the same test for setting the new connection attribute to either false
or true creating a stored procedure that returns multiple result sets.

see: https://github.com/php/php-src/pull/896

Thanks,

Peter