Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79285
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFMT4NoV-Gp+ax+aXpR5Th8cmS+rrvmx7QKD4nw-w-Q9mV79-w@mail.gmail.com>
References: <CAFMT4Npco8sQ-+5hpUNa3pu5L2q7mnCVnsCjZee=NbNDrkwLUw@mail.gmail.com>
	<5477010E.4000000@gmail.com>
	<CA+9eiLvz6nLcCuQbxkR4j3KVXOm_rsQFLzfbeMwfU6AGysc0xg@mail.gmail.com>
	<CAFMT4NoV-Gp+ax+aXpR5Th8cmS+rrvmx7QKD4nw-w-Q9mV79-w@mail.gmail.com>
Date: Fri, 28 Nov 2014 22:37:23 +0400
Message-ID: <CA+9eiLtp6jXi4q7XytNjN9_retqjCtn_0ZGD4ooLYfa75gaozg@mail.gmail.com>
To: Levi Morrison <levim@php.net>
Cc: Rowan Collins <rowan.collins@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec547cbdd4318320508ef8df7
Subject: Re: [PHP-DEV] [RFC][Discussion] Return Type Variance Checking
From: dmitry@zend.com (Dmitry Stogov)

--bcaec547cbdd4318320508ef8df7
Content-Type: text/plain; charset=UTF-8

Hi Levi,

if you remember, in my patch return_type was actually stored in
arg_info[-1].
it was mainly done for unification and to allow return type hinting for
internal functions (they already use arg_info[-1])
So the strictures may be compatible.
See https://gist.github.com/dstogov/8deb8b17e41c1a5abf88

I also thought about zend_string* usage in arg_info
Please review the patch if you missed it.
https://gist.github.com/dstogov/aa452a47ec30a8cb6eb5

The patches may be outdated, but they worked.
I may care about the final implementation if you agree with invariant
return type.

Thanks. Dmitry.



On Fri, Nov 28, 2014 at 7:51 PM, Levi Morrison <levim@php.net> wrote:

> > I prefer option (3) - invariant return types.
> > Actually, return type compatibility check should follow all the rules for
> > parameter type compatibility check (may be even reuse or share the code).
>
> Realistically there isn't much code to share, especially since the two
> structures are incompatible. That is, they are incompatible until
> `zend_string *` is used in parameters (which I'm hopeful will happen).
>

--bcaec547cbdd4318320508ef8df7--