Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:79257 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 88291 invoked from network); 28 Nov 2014 04:33:59 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Nov 2014 04:33:59 -0000 Authentication-Results: pb1.pair.com header.from=laruence@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=laruence@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.47 as permitted sender) X-PHP-List-Original-Sender: laruence@gmail.com X-Host-Fingerprint: 209.85.215.47 mail-la0-f47.google.com Received: from [209.85.215.47] ([209.85.215.47:39872] helo=mail-la0-f47.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 44/64-59154-03BF7745 for ; Thu, 27 Nov 2014 23:33:54 -0500 Received: by mail-la0-f47.google.com with SMTP id hz20so4959637lab.6 for ; Thu, 27 Nov 2014 20:33:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=WIlfjYrndf56SrOQlxAMJ39uQlrpOUnJyTH+w6fFVdw=; b=QOFadjKxvjZbc/zXycLr+sBKDwNOlocoNJa2Hmrw54QxnCvW+dgZBYsHkqEIucakLc wJOVKdnP/6rCfHEqHz5zJu7nzk4ur2KejoSXg7DIEOkS9AEuRo00LIcFe/4is/cbU2tf Rz87GpWfXCge4K71vYTOOI2r5SQmzc39oo4aroJTGj0xDuH8gn9oaSezarbWc0hZyAak WJ7iwIRQcS4WGhuzCgWrxAu2kYm/KdZ9WrvLB2bRlmvT7TEHv0tNQ7LYi7yNNirTLFOW UNiH+102tdY+/9xT8/PkDI1pAdqEABtM7pUU0dmM9+QgVYE3T9lkVsfPkbLZ/sT1IaPW XmVg== X-Received: by 10.152.5.167 with SMTP id t7mr19874108lat.9.1417149229346; Thu, 27 Nov 2014 20:33:49 -0800 (PST) MIME-Version: 1.0 Sender: laruence@gmail.com Received: by 10.114.64.176 with HTTP; Thu, 27 Nov 2014 20:33:29 -0800 (PST) In-Reply-To: References: Date: Fri, 28 Nov 2014 12:33:29 +0800 X-Google-Sender-Auth: XeppynqmnZcl3QfnDjWNs2PSULc Message-ID: To: Dmitry Stogov Cc: Nikita Popov , Matteo Beccati , PHP Internals Content-Type: text/plain; charset=UTF-8 Subject: Re: EX(scope) removing From: xinchen.h@zend.com (Xinchen Hui) Hey: On Fri, Nov 28, 2014 at 1:27 AM, Dmitry Stogov wrote: > Hi, > > I'm working on call/return sequence optimization. As part of this work I'm > minimizing the size of call frame (zend_execute_data) and number of > read/write operations on call/return. > > Could you please take a look into the patch that removes EX(scope) > https://gist.github.com/dstogov/5ad50d582346385d587e > > All phpt tests are passed, but I'm not completely sure about one line - > https://gist.github.com/dstogov/5ad50d582346385d587e#file-ex_scope-05-diff-L193 > > On the other hand I can't imagine what it may break. neither do I. > > Matteo, can you please run your test suites with this patch. > > PS: I'm also going to: > - pack EX(num_args) into reserved space of EX(This) > - try to get rid of EX(frame_info) > - try to merge EX(called_scope) and EX(This). Only one of them matters. > - try to replace zval EX(This) with a pointer to zend_object EX(object) Hmm, EX(This) is not like EX(object), it will be accessed by vm handler: get_obj_zval_ptr_unused it suppores to return a zval * there. if EX(This) became a zend_object *, then we may face different handlers for IS_UNUSED and other types :< thanks > > Thanks. Dmitry. -- Xinchen Hui @Laruence http://www.laruence.com/