Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79253
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFMT4NqDzYtgzOLnOEgxLZO_Xyd37MbozKPQJVOR27YWBJxXEg@mail.gmail.com>
References: <CA+9eiLuiLUoKRrR7_Mp2UmYKMpwqcUPQ+Kd8zixuLQ3TQv7CTg@mail.gmail.com>
	<CAFMT4Nou2Q4iCZwcRObyuWNVSLajsawMwUOehm=sPuGCwP7Y7w@mail.gmail.com>
	<CAFMT4NqDzYtgzOLnOEgxLZO_Xyd37MbozKPQJVOR27YWBJxXEg@mail.gmail.com>
Date: Fri, 28 Nov 2014 02:54:59 +0400
Message-ID: <CA+9eiLs=z=YRVfcujtpEWPSMhj85DHT_Lo-wpJ7ZDdSmk8LwMw@mail.gmail.com>
To: Levi Morrison <levim@php.net>
Cc: Nikita Popov <nikita.ppv@gmail.com>, Xinchen Hui <xinchen.h@zend.com>, 
	Matteo Beccati <matteo@beccati.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b33da24a686a70508df0853
Subject: Re: [PHP-DEV] EX(scope) removing
From: dmitry@zend.com (Dmitry Stogov)

--047d7b33da24a686a70508df0853
Content-Type: text/plain; charset=UTF-8

Yes, we may store EX(called_scope) in EX(This).value.ce and set another
type and/or flag(s).
But it shouldn't slowdown $this access in _get_obj_zval_ptr_unused() and
other often used functions.
If it's possible, we may try to merge, if not, it doesn't make sense.

Thanks. Dmitry.

On Thu, Nov 27, 2014 at 11:05 PM, Levi Morrison <levim@php.net> wrote:

> On Thu, Nov 27, 2014 at 12:59 PM, Levi Morrison <levim@php.net> wrote:
> >> - try to merge EX(called_scope) and EX(This). Only one of them matters.
> >
> > We could use the void *ptr in a zval (or add it to the available types
> > in the union) and add another flag for zval type. Anyone have an
> > objection with that?
>
> I just noticed we already support putting zend_class_entry* in zvals;
> I'm not exactly sure what the internal representation of This is off
> the top of my head, though; would they be compatible?
>

--047d7b33da24a686a70508df0853--