Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79245
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <547768EB.3050506@beccati.com>
References: <CA+9eiLuiLUoKRrR7_Mp2UmYKMpwqcUPQ+Kd8zixuLQ3TQv7CTg@mail.gmail.com>
	<547768EB.3050506@beccati.com>
Date: Thu, 27 Nov 2014 23:42:40 +0400
Message-ID: <CA+9eiLsrwiRVfg2eaAFoMkiLRhwGAwCsabgwRxMOUK9uQYCi9A@mail.gmail.com>
To: Matteo Beccati <php@beccati.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>, Xinchen Hui <xinchen.h@zend.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1135fa5adec7d80508dc583b
Subject: Re: [PHP-DEV] EX(scope) removing
From: dmitry@zend.com (Dmitry Stogov)

--001a1135fa5adec7d80508dc583b
Content-Type: text/plain; charset=UTF-8

Thanks. Probably, I'll commit it tomorrow.

Dmitry.

On Thu, Nov 27, 2014 at 9:09 PM, Matteo Beccati <php@beccati.com> wrote:

> Hi Dmitry,
>
> On 27/11/2014 18:27, Dmitry Stogov wrote:
>
>> Could you please take a look into the patch that removes EX(scope)
>> https://gist.github.com/dstogov/5ad50d582346385d587e
>>
>> All phpt tests are passed, but I'm not completely sure about one line -
>> https://gist.github.com/dstogov/5ad50d582346385d587e#
>> file-ex_scope-05-diff-L193
>>
>> On the other hand I can't imagine what it may break.
>>
>> Matteo, can you please run your test suites with this patch.
>>
>
> Done. No regressions found for:
>
> * run-tests
> * Revive Adserver + MySQL & Postgres
> * PHPUnit
> * phpspec
> * Doctrine2 + SQLite & Postgres
>
>
> Cheers
> --
> Matteo Beccati
>
> Development & Consulting - http://www.beccati.com/
>

--001a1135fa5adec7d80508dc583b--