Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:79243 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 35581 invoked from network); 27 Nov 2014 18:10:02 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Nov 2014 18:10:02 -0000 Authentication-Results: pb1.pair.com header.from=php@beccati.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=php@beccati.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain beccati.com designates 176.9.114.167 as permitted sender) X-PHP-List-Original-Sender: php@beccati.com X-Host-Fingerprint: 176.9.114.167 spritz.beccati.com Received: from [176.9.114.167] ([176.9.114.167:38250] helo=mail.beccati.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id AA/77-27910-7F867745 for ; Thu, 27 Nov 2014 13:10:00 -0500 Received: (qmail 8151 invoked from network); 27 Nov 2014 18:09:54 -0000 Received: from home.beccati.com (HELO ?192.168.1.202?) (88.149.176.119) by mail.beccati.com with SMTP; 27 Nov 2014 18:09:54 -0000 Message-ID: <547768EB.3050506@beccati.com> Date: Thu, 27 Nov 2014 19:09:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Dmitry Stogov , Nikita Popov , Xinchen Hui , PHP Internals References: In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] EX(scope) removing From: php@beccati.com (Matteo Beccati) Hi Dmitry, On 27/11/2014 18:27, Dmitry Stogov wrote: > Could you please take a look into the patch that removes EX(scope) > https://gist.github.com/dstogov/5ad50d582346385d587e > > All phpt tests are passed, but I'm not completely sure about one line - > https://gist.github.com/dstogov/5ad50d582346385d587e#file-ex_scope-05-diff-L193 > > On the other hand I can't imagine what it may break. > > Matteo, can you please run your test suites with this patch. Done. No regressions found for: * run-tests * Revive Adserver + MySQL & Postgres * PHPUnit * phpspec * Doctrine2 + SQLite & Postgres Cheers -- Matteo Beccati Development & Consulting - http://www.beccati.com/