Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79131
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.45 as permitted sender)
User-Agent: K-9 Mail for Android
In-Reply-To: <018601d00776$50681c40$f13854c0$@devtemple.com>
References: <012701d0074c$ccfe6f40$66fb4dc0$@devtemple.com> <7E8EF92A-6071-4BDA-ADD5-2C2B54AA2DCB@gmail.com> <018601d00776$50681c40$f13854c0$@devtemple.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain;
 charset=UTF-8
Date: Mon, 24 Nov 2014 19:14:34 +0000
To: internals@lists.php.net
Message-ID: <37158DB6-5CFA-4B64-944A-AAF78BDA4566@gmail.com>
Subject: RE: [PHP-DEV] enhance fget to accept a callback
From: rowan.collins@gmail.com (Rowan Collins)

On 23 November 2014 23:36:30 GMT, Bill Salak <bill@devtemple.com> wrote:
>The callback would be given the string as returned by fgets today. The
>functional equivalent to fgetjson today is handled by something like 
>$handle = fopen(~some file~, 'r');
>while (($data = fgets($handle)) !== FALSE) {
>    $data = json_decode($data, true);
>    ...other stuff...
>}
>and would change to
>$handle = fopen(~some file~, 'r');
>$decode = json_decode($data, true);
>while (($data = fgets($handle,0,$decode)) !== FALSE) {
>   ...other stuff...
>}

Since you need a function reference for the callback, you'd actually need a closure to capture the options:

$decode = function($data) { return json_decode($data, true); };

This is actually more effort and code than the existing version, so I'm not sure what is gained.

Either way, the likelihood is you'd want to wrap this into a user function. As I mentioned earlier, making it into an Iterator is often useful, and potentially as simple as a generator function a bit like this:

function fjsoniterator($fh) {
    if ( ! feof($fh) ) {
        yield json_decode(fgets($fh), true);
    }
}

$fh = fopen(...);
foreach ( fjsoniterator($fh) as $data ) { ... }

Regards,
-- 
Rowan Collins
[IMSoP]