Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79128
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.172 as permitted sender)
MIME-Version: 1.0
References: <D7C8CEF6-625E-4489-8EFC-8FCAA16302D2@ajf.me> <CAFMT4NodhUcS3f-nnCpxGuR=AA6-g9wTchzeS7faTeu9SSL5xw@mail.gmail.com>
Date: Mon, 24 Nov 2014 16:08:03 +0000
Message-ID: <CACwt+JfWULbrJrorM96v35S5=ef8aFrVZTn+4W-7pi_nJUuxkg@mail.gmail.com>
To: Levi Morrison <levim@php.net>, Andrea Faulds <ajf@ajf.me>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c365aed7476205089cffd3
Subject: Re: [PHP-DEV] [VOTE][RFC] Safe Casting Functions
From: patrickallaert@php.net (Patrick ALLAERT)

--001a11c365aed7476205089cffd3
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Le Wed Nov 19 2014 at 10:57:39 PM, Levi Morrison <levim@php.net> a =C3=A9cr=
it :
>
>   - PHP suffers a lot from function bloat and this RFC provides
> multiple functions that do the same thing but differ only in how they
> handle errors. A simple validation of "can this be safely cast to an
> integer without dataloss?" avoid the issue entirely and would be fewer
> functions.
>

My "no" is mostly for the reason above, mentioned by Levi and also because
of the use of Exception (previously mentioned by Derick as well).

To improve this RFC, I would:
- use errors/warnings instead of exceptions (unless there is a more global
approach on this aspect for PHP 7).
- improve ext/filter to have stricter validation/sanitizing mechanism if
this is missing.

I would personally appreciate a syntax closer to the current casting
mechanism, e.g.:

    $int =3D (=3Dint) "42"; // result: (int) 42
    $string =3D (=3Dstring) 42; // result: (string) "42"
    $int =3D (=3Dint) "foobar"; // result: E_ERROR: Can not cast (string)
"foobar" strictly to an int

    $int =3D (~int) "42"; // result: (int) 42
    $int =3D (~int) "foobar"; // result: E_WARNING: Can not cast (string)
"foobar" strictly to an int

Note that I haven't investigate any possible syntax conflict.

My 2 =E2=82=ACcents.

Regards,
Patrick

--001a11c365aed7476205089cffd3--