Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79120
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+9eiLsp95Tk3DMbXNW191PnxbWeErDkjGK3XuL8scQ31+k6WA@mail.gmail.com>
References: <546B0F62.1090705@gmail.com>
	<CA+9eiLsyGN_z8hyxNFn3VPXWb5Gd0txB9Ks=sqzGxzh4USHudw@mail.gmail.com>
	<546E3656.2010608@gmail.com>
	<546EB8B3.3020807@gmail.com>
	<CA+9eiLsp95Tk3DMbXNW191PnxbWeErDkjGK3XuL8scQ31+k6WA@mail.gmail.com>
Date: Mon, 24 Nov 2014 13:56:57 +0400
Message-ID: <CA+9eiLt74yhxBVUQdufhmw6Z7Y9DS1BToYMeu0fC-YpV9AoCow@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec547cbdda81652050897d041
Subject: Re: [PHP-DEV] [RFC] Default constructors
From: dmitry@zend.com (Dmitry Stogov)

--bcaec547cbdda81652050897d041
Content-Type: text/plain; charset=UTF-8

I like the last patch. I think ZEND_ACC_STATIC flag must not make any
problems.

However, I thought about one more inconsistent. Your patch works fine for
"parent::" methods but not for "grandparents::"
In the following code "default constructor" won't work.

class A {
}
class B extends A {
}
class C extends B {
  function __constructor() {
    A::_constructor(); // this won't work
  }
}

It's not a big problem to fix implementation to support it, or may be
support for "parent::" is enough.
Anyway, it should be reflected in RFC (if this code should work or should
not).

Thanks. Dmitry.


On Fri, Nov 21, 2014 at 10:40 AM, Dmitry Stogov <dmitry@zend.com> wrote:

> thanks Stas. I'll think on next week.
>
> Dmitry.
>
> On Fri, Nov 21, 2014 at 6:59 AM, Stanislav Malyshev <smalyshev@gmail.com>
> wrote:
>
>> Hi!
>>
>> >> Additional check for ZEND_NULL_FUNCTION in DO_FCALL may be expensive.
>> >> I think it must be better to use special predefined function (see
>> >> "zend_pass_function" usage in zend_vm_def.h).
>>
>> I've made a different implementation here:
>>
>> https://github.com/smalyshev/php-src/compare/php:master...smalyshev:default_ctor_func?expand=1
>>
>> which uses zend_pass_function but I had to make it static since
>> otherwise it's increase refcount for object and it doesn't seem like it
>> decrements back. So I'm not sure if it's right, what do you think?
>>
>> --
>> Stas Malyshev
>> smalyshev@gmail.com
>>
>
>

--bcaec547cbdda81652050897d041--