Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:791 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 40200 invoked from network); 8 Apr 2003 15:40:30 -0000 Received: from unknown (HELO firewall.bmh.local) (4.61.245.27) by pb1.pair.com with SMTP; 8 Apr 2003 15:40:30 -0000 Received: from firewall.bmh.local (localhost [IPv6:::1]) by firewall.bmh.local (8.12.6/8.12.6) with ESMTP id h38FppqQ025068; Tue, 8 Apr 2003 08:51:51 -0700 (PDT) Received: from localhost (chrisv@localhost) by firewall.bmh.local (8.12.6/8.12.6/Submit) with ESMTP id h38FpNmh028955; Tue, 8 Apr 2003 08:51:36 -0700 (PDT) X-Authentication-Warning: firewall.bmh.local: chrisv owned process doing -bs Date: Tue, 8 Apr 2003 08:51:22 -0700 (PDT) X-X-Sender: chrisv@firewall.bmh.local Reply-To: chrisv@revhosting.com To: Jan Schneider cc: internals@lists.php.net In-Reply-To: <1049801703.c2dce36790dd6@jan.dip.ammma.net> Message-ID: MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-243559841-1049817082=:2236" Subject: Re: [PHP-DEV] ext/xml handlers currently broken? From: chrisv@revhosting.com (Chris Vandomelen) References: <1049801703.c2dce36790dd6@jan.dip.ammma.net> --0-243559841-1049817082=:2236 Content-Type: TEXT/PLAIN; charset=US-ASCII > Hi! > > It looks like the xml_set_*_handler() functions are currently broken. > Code that works perfectly with the PHP_4_3 branch fails with HEAD and > produces messages like: > > Warning: xml_parse(): Unable to call handler startElement() in ... > Will the attached patch fix the problem? It seems to be the appropriate fix, since all that appears to be wrong is the usage of the global function table instead of the object's function table. (I'd test it, but I've made my share of changes to ZE2 that are doubtful at best to be committed anyway...) Chris --0-243559841-1049817082=:2236 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="xml-call-handler.diff.txt" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename="xml-call-handler.diff.txt" SW5kZXg6IHhtbC5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmls ZTogL3JlcG9zaXRvcnkvcGhwNC9leHQveG1sL3htbC5jLHYNCnJldHJpZXZp bmcgcmV2aXNpb24gMS4xMTcNCmRpZmYgLXUgLXIxLjExNyB4bWwuYw0KLS0t IHhtbC5jCTMgQXByIDIwMDMgMDE6MDA6NDUgLTAwMDAJMS4xMTcNCisrKyB4 bWwuYwk4IEFwciAyMDAzIDE1OjIxOjM2IC0wMDAwDQpAQCAtMzcwLDExICsz NzAsMTYgQEANCiAJCXp2YWwgKnJldHZhbDsNCiAJCWludCBpOwkNCiAJCWlu dCByZXN1bHQ7DQorCQlIYXNoVGFibGUgKmZ1bmN0aW9uX3RhYmxlOw0KIA0K IAkJTUFLRV9TVERfWlZBTChyZXR2YWwpOw0KIAkJWlZBTF9GQUxTRShyZXR2 YWwpOw0KIA0KLQkJcmVzdWx0ID0gY2FsbF91c2VyX2Z1bmN0aW9uKEVHKGZ1 bmN0aW9uX3RhYmxlKSwgJnBhcnNlci0+b2JqZWN0LCBoYW5kbGVyLCByZXR2 YWwsIGFyZ2MsIGFyZ3YgVFNSTUxTX0NDKTsNCisJCWZ1bmN0aW9uX3RhYmxl ID0gRUcoZnVuY3Rpb25fdGFibGUpOw0KKwkJaWYgKHBhcnNlci0+b2JqZWN0 KQ0KKwkJCWZ1bmN0aW9uX3RhYmxlID0gWl9PQkpDRV9QKHBhcnNlci0+b2Jq ZWN0KS0+ZnVuY3Rpb25fdGFibGU7DQorDQorCQlyZXN1bHQgPSBjYWxsX3Vz ZXJfZnVuY3Rpb24oZnVuY3Rpb25fdGFibGUsICZwYXJzZXItPm9iamVjdCwg aGFuZGxlciwgcmV0dmFsLCBhcmdjLCBhcmd2IFRTUk1MU19DQyk7DQogDQog CQlpZiAocmVzdWx0ID09IEZBSUxVUkUpIHsNCiAJCQl6dmFsICoqbWV0aG9k Ow0K --0-243559841-1049817082=:2236--