Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79086
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFMT4NpJxuuqc-wTr1aE4K+wZBT8+04j+9-SsY+nhUMU83fDUg@mail.gmail.com>
References: <CAFMT4NpJxuuqc-wTr1aE4K+wZBT8+04j+9-SsY+nhUMU83fDUg@mail.gmail.com>
Date: Fri, 21 Nov 2014 17:22:49 +0100
Message-ID: <CAF+90c8Lf4CZw75MicKCz_h8wUpvPAyrhHgnrSpZJQeNioP1Aw@mail.gmail.com>
To: Levi Morrison <levim@php.net>
Cc: internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b8742cc1fec77050860db86
Subject: Re: [PHP-DEV] [RFC] Remove PHP 4 Constructors
From: nikita.ppv@gmail.com (Nikita Popov)

--047d7b8742cc1fec77050860db86
Content-Type: text/plain; charset=UTF-8

On Wed, Nov 19, 2014 at 12:11 AM, Levi Morrison <levim@php.net> wrote:

> Dear Internals,
>
> I am proposing an RFC[1] to remove PHP 4 constructors in PHP 7. If
> accepted, methods with the same name as their defining class will no
> longer be recognized as constructors. As noted in the RFC, there are
> already many situations where we do not recognize these methods as
> constructors, such as in namespaces and traits and when `function
> __construct` is also present.
>
> Andrea Faulds has kindly written a utility that identifies when a PHP
> 4 constructor is defined[2]. It does not automatically change the code
> for liability reasons. The utility PHPMD[3] can also detect this but
> has a false positive when `__construct` is also defined.
>
> Cheers,
> Levi Morrison
>

I'm +1 on this RFC.

I've lost count of the number of times I had to debug some "completely
impossible" behavior I got while writing quick testing code (which is
obviously not namespaced), because I accidentally created a class "Test"
with a method "test" or similar.

I'm also pretty confident that we can provide robust tooling for
automatically porting code to new constructors - including updating
parent:: call references if need be. Don't see how that would be a
particular issue here.

Nikita

--047d7b8742cc1fec77050860db86--