Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:79065 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 71174 invoked from network); 21 Nov 2014 07:40:42 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Nov 2014 07:40:42 -0000 Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.172 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 209.85.220.172 mail-vc0-f172.google.com Received: from [209.85.220.172] ([209.85.220.172:40873] helo=mail-vc0-f172.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D1/A5-32541-77CEE645 for ; Fri, 21 Nov 2014 02:40:39 -0500 Received: by mail-vc0-f172.google.com with SMTP id hq11so2135502vcb.31 for ; Thu, 20 Nov 2014 23:40:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=sINMfGTePaABXC9i0NOipGSZ9v09LPmr12tS3jnLobA=; b=FvcENvUk/6oIYOadiSDzIOzq0P9rUZo8ePeOO1wgdEXZPjX3Gd98SkAYpVSCqFQFFI tHLvek9btBXUWAF6sMIhXk6dNTeZbD/avNdkgnxKkXkyUfAd8OanfvVr+dDhyHWsDrMH i8FR3Eh0eqHMAEFny6pcZfNjNiwWp8HaEpkHQTnKeCamryuJjtNs3GIetqSCwLXQGKtX +DZ5wpMPZWS20cQ8qgyxMjFMrtxvdkNtTTz9+wSr9nLFtOQQck6NIPduXmLN1v++82+1 cFnqT/BDeAyAwTMUeYh5IdeeWLVHcyPnHRWfgEUwb3SVuRFE9QKFj6PG4kh/VnkTdm4r 1chg== X-Gm-Message-State: ALoCoQlZC2DC3gucrGe/0VVvBEeRlYj1ynbTpsIfki0HRwAda4s1vU2lqWorauizQFMCWE3An2CzWQBYhz54v0PWTdmeTGDzob3TsvXXYMRpjtpQwnqYMKVc/4vqM2bTc7ZWzi1VV1hVLqYYXIaN1Uw8z7JQoFLA4w== MIME-Version: 1.0 X-Received: by 10.52.117.161 with SMTP id kf1mr2642674vdb.65.1416555636345; Thu, 20 Nov 2014 23:40:36 -0800 (PST) Received: by 10.52.176.231 with HTTP; Thu, 20 Nov 2014 23:40:36 -0800 (PST) In-Reply-To: <546EB8B3.3020807@gmail.com> References: <546B0F62.1090705@gmail.com> <546E3656.2010608@gmail.com> <546EB8B3.3020807@gmail.com> Date: Fri, 21 Nov 2014 11:40:36 +0400 Message-ID: To: Stanislav Malyshev Cc: PHP Internals Content-Type: multipart/alternative; boundary=bcaec547cbdd8267b80508598f55 Subject: Re: [PHP-DEV] [RFC] Default constructors From: dmitry@zend.com (Dmitry Stogov) --bcaec547cbdd8267b80508598f55 Content-Type: text/plain; charset=UTF-8 thanks Stas. I'll think on next week. Dmitry. On Fri, Nov 21, 2014 at 6:59 AM, Stanislav Malyshev wrote: > Hi! > > >> Additional check for ZEND_NULL_FUNCTION in DO_FCALL may be expensive. > >> I think it must be better to use special predefined function (see > >> "zend_pass_function" usage in zend_vm_def.h). > > I've made a different implementation here: > > https://github.com/smalyshev/php-src/compare/php:master...smalyshev:default_ctor_func?expand=1 > > which uses zend_pass_function but I had to make it static since > otherwise it's increase refcount for object and it doesn't seem like it > decrements back. So I'm not sure if it's right, what do you think? > > -- > Stas Malyshev > smalyshev@gmail.com > --bcaec547cbdd8267b80508598f55--