Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79064
Return-Path: <smalyshev@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 58594 invoked from network); 21 Nov 2014 03:59:54 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 21 Nov 2014 03:59:54 -0000
Authentication-Results: pb1.pair.com header.from=smalyshev@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=smalyshev@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.41 as permitted sender)
X-PHP-List-Original-Sender: smalyshev@gmail.com
X-Host-Fingerprint: 209.85.220.41 mail-pa0-f41.google.com  
Received: from [209.85.220.41] ([209.85.220.41:45164] helo=mail-pa0-f41.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id A1/34-32541-9B8BE645 for <internals@lists.php.net>; Thu, 20 Nov 2014 22:59:54 -0500
Received: by mail-pa0-f41.google.com with SMTP id rd3so3965527pab.28
        for <internals@lists.php.net>; Thu, 20 Nov 2014 19:59:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=message-id:date:from:user-agent:mime-version:to:cc:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        bh=XbBfkqIu5s4i9AeZV653HsTho9IKsU+xHAUyYOHVGGY=;
        b=0xM9x0urNy8eEhrAvo5dXEN0n8rFPWhpD1sJn+5WrV9ImpWtWx/yDa37eY77xmtWol
         H8AYMFfg57ffunIgf5UQ6kUhEU09FNRT/smgB51tZsc4UTk913fqmneAkjpiw4EWHoX9
         6pYuALI8Ge3nsbdeBQkQEne+T4WvwGIXya9pHHz31cMXgvjaikjVniOGh0wRZk8LERvV
         PtzjUedoL0pV5xxqRevQayS9Ac9eXdBehN6LM/pzec7QiYYW7LKXtcGQK5iBdHD5wpSn
         KBCO7HZFF1a93dw0oTzoFWxeglV3S4cwVrvMU3oX0M6AFGkwhrHOvwb/ZyFgUrZQhZvH
         8vZQ==
X-Received: by 10.68.164.101 with SMTP id yp5mr3211520pbb.66.1416542391060;
        Thu, 20 Nov 2014 19:59:51 -0800 (PST)
Received: from [192.168.2.102] (108-66-6-48.lightspeed.sntcca.sbcglobal.net. [108.66.6.48])
        by mx.google.com with ESMTPSA id s7sm3353652pdi.72.2014.11.20.19.59.48
        for <multiple recipients>
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Thu, 20 Nov 2014 19:59:48 -0800 (PST)
Message-ID: <546EB8B3.3020807@gmail.com>
Date: Thu, 20 Nov 2014 19:59:47 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Dmitry Stogov <dmitry@zend.com>
CC: PHP Internals <internals@lists.php.net>
References: <546B0F62.1090705@gmail.com> <CA+9eiLsyGN_z8hyxNFn3VPXWb5Gd0txB9Ks=sqzGxzh4USHudw@mail.gmail.com> <546E3656.2010608@gmail.com>
In-Reply-To: <546E3656.2010608@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Default constructors
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

>> Additional check for ZEND_NULL_FUNCTION in DO_FCALL may be expensive.
>> I think it must be better to use special predefined function (see
>> "zend_pass_function" usage in zend_vm_def.h).

I've made a different implementation here:
https://github.com/smalyshev/php-src/compare/php:master...smalyshev:default_ctor_func?expand=1

which uses zend_pass_function but I had to make it static since
otherwise it's increase refcount for object and it doesn't seem like it
decrements back. So I'm not sure if it's right, what do you think?

-- 
Stas Malyshev
smalyshev@gmail.com