Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79053
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.215.10 cause and error)
Message-ID: <1416519555.15061.43.camel@kuechenschabe>
To: Levi Morrison <levim@php.net>
Cc: Alain Williams <addw@phcomp.co.uk>, internals <internals@lists.php.net>
Date: Thu, 20 Nov 2014 22:39:15 +0100
In-Reply-To: <CAFMT4NoCDJgnG554LO-yNzQ5TYpLVfx7FuaJHMHw_tO-H0Utkw@mail.gmail.com>
References: 
	<CAFMT4NpJxuuqc-wTr1aE4K+wZBT8+04j+9-SsY+nhUMU83fDUg@mail.gmail.com>
	 <546C9E22.6090301@fedoraproject.org> <20141119134632.GV2294@phcomp.co.uk>
	 <546CA8C0.1060707@gmail.com> <20141119143329.GX2294@phcomp.co.uk>
	 <1416476628.15061.4.camel@kuechenschabe>
	 <CAFMT4NoHNKHmck_rkAEWo9zx8A1Z5d_pTtaC+jOGXqV7SxkUAQ@mail.gmail.com>
	 <1416502819.15061.38.camel@kuechenschabe>
	 <CAFMT4NoCDJgnG554LO-yNzQ5TYpLVfx7FuaJHMHw_tO-H0Utkw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] Remove PHP 4 Constructors
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

On Thu, 2014-11-20 at 13:54 -0700, Levi Morrison wrote:
> > It is a non-trivial change. Fixing this is not always as some people
> > might suggest.
> 
> 1) Identify PHP 4 constructors using one of several tools (including
> upgrading to PHP 5.7 and getting E_DEPRECATEDs).
> 2) Use one of the several tools that support method rename refactoring
> (Netbeans, PhpStorm, and others) to rename the methods to __construct.
> 
> You could probably automate it with a very high degree of success; I
> just don't want to automatically change code for liability reasons.  I
> think you are exaggerating the required work given the tools we have
> at our disposal…

No you can't. (ok *you* can but not 90% of our users, those depend on
external libraries/tools and those can't simply change their API without
hurting their adoption rate, which in turn hurts our adoption rate)

> I am proposing E_DEPRECATED in PHP 5.7, just as the RFC for using
> multiple default statements in switches (which was accepted, by the
> way).
> 
> Updating to PHP 5.7 first gives you more time to prepare for this and
> other BC breaks for PHP 7. There are already a few, and I suspect
> we'll have a few more before it's shipped.

Yay! Instead of helping users to keep up to date and respecting their
needs we give them reasons to stay on old versions for making things
"cleaner". How wonderful.

All things said for this thread.

johannes