Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79051
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.44 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <1416502819.15061.38.camel@kuechenschabe>
References: <CAFMT4NpJxuuqc-wTr1aE4K+wZBT8+04j+9-SsY+nhUMU83fDUg@mail.gmail.com>
	<546C9E22.6090301@fedoraproject.org>
	<20141119134632.GV2294@phcomp.co.uk>
	<546CA8C0.1060707@gmail.com>
	<20141119143329.GX2294@phcomp.co.uk>
	<1416476628.15061.4.camel@kuechenschabe>
	<CAFMT4NoHNKHmck_rkAEWo9zx8A1Z5d_pTtaC+jOGXqV7SxkUAQ@mail.gmail.com>
	<1416502819.15061.38.camel@kuechenschabe>
Date: Thu, 20 Nov 2014 13:54:00 -0700
Message-ID: <CAFMT4NoCDJgnG554LO-yNzQ5TYpLVfx7FuaJHMHw_tO-H0Utkw@mail.gmail.com>
To: =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>
Cc: Alain Williams <addw@phcomp.co.uk>, internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] Remove PHP 4 Constructors
From: levim@php.net (Levi Morrison)

>> I just want to make sure I understand you correctly: you are saying
>> you are voting no on this RFC because a tool, which is not part of
>> this RFC but we kindly provide, doesn't detect when a certain thing is
>> called?
>
> It is a non-trivial change. Fixing this is not always as some people
> might suggest.

1) Identify PHP 4 constructors using one of several tools (including
upgrading to PHP 5.7 and getting E_DEPRECATEDs).
2) Use one of the several tools that support method rename refactoring
(Netbeans, PhpStorm, and others) to rename the methods to __construct.

You could probably automate it with a very high degree of success; I
just don't want to automatically change code for liability reasons.  I
think you are exaggerating the required work given the tools we have
at our disposal=E2=80=A6

=E2=80=A6but that's okay. You can think and vote however you chose.

> We can deprecate it in 7 (and fix code in our distribution) and then
> take a next step in a later version, though.

I am proposing E_DEPRECATED in PHP 5.7, just as the RFC for using
multiple default statements in switches (which was accepted, by the
way).

Updating to PHP 5.7 first gives you more time to prepare for this and
other BC breaks for PHP 7. There are already a few, and I suspect
we'll have a few more before it's shipped.