Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79014
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.175 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <D7C8CEF6-625E-4489-8EFC-8FCAA16302D2@ajf.me>
References: <D7C8CEF6-625E-4489-8EFC-8FCAA16302D2@ajf.me>
Date: Wed, 19 Nov 2014 14:57:05 -0700
Message-ID: <CAFMT4NodhUcS3f-nnCpxGuR=AA6-g9wTchzeS7faTeu9SSL5xw@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [VOTE][RFC] Safe Casting Functions
From: levim@php.net (Levi Morrison)

> Since some things might have changed since you last read the RFC, I encourage you to read through it again. If there are any questions which have not yet been covered on the mailing list, feel free to ask them.

  - The RFC does not address how this is different from
FILTER_VALIDATE_* from ext/filter. I know there was a mention of this
on the mailing list, but the RFC should say why a tool that already
exists to solve this kind of problem is insufficient, especially when
it is enabled by default.
  - PHP suffers a lot from function bloat and this RFC provides
multiple functions that do the same thing but differ only in how they
handle errors. A simple validation of "can this be safely cast to an
integer without dataloss?" avoid the issue entirely and would be fewer
functions.

To summarize: I like the idea of having tools that helps us convert
between types in a lossless way, but I don't think this proposal is
what is best for PHP. -1 for me but I hope to see this revisited.