Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78958
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <A67B5C10-D038-41BC-A54D-7A588B09FE49@ajf.me>
References: <CAFp73Xu9yq6qLaYUO57CHj4=1g=naxQceNV4fNMca73e6WjpJw@mail.gmail.com>
 <A67B5C10-D038-41BC-A54D-7A588B09FE49@ajf.me>
Date: Tue, 18 Nov 2014 15:51:20 -0500
Message-ID: <CAFp73XsfFZNRFXu+tOTzp3LfgfNFk-NoFYCArkzwygFmwx3CxQ@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0103de4e0f74ff05082843b6
Subject: Re: [PHP-DEV] [IDEA] Class modifiers support expansion
From: guilhermeblanco@gmail.com ("guilhermeblanco@gmail.com")

--089e0103de4e0f74ff05082843b6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I think parts of this can easily be handled in zend_compile.
Other pieces requires runtime introspection that could be done at
zend_vm_def. My only concern is how to know what's the active scope
(class)...

While researching for data flow, I also saw that with the inclusion of AST,
some checks currently in zend_inheritance could be moved to zend_compile
too.

If we can discuss and reach some consensus, I can work (or at least try to)
on a patch and propose officially as an RFC. But before doing that, we need
to resolve how private/protected should behave. My suggestion could work,
but it may not be a sane approach.

[]s,

On Tue, Nov 18, 2014 at 12:58 PM, Andrea Faulds <ajf@ajf.me> wrote:

>
> > On 18 Nov 2014, at 17:33, guilhermeblanco@gmail.com wrote:
> >
> > Library developers sometimes plan for extensibility of their code, but
> not
> > all pieces are able to be extended and unexpected usage can lead to
> > unpredictable behavior.
> > Based on that, I consider it may be a good addition to PHP to add class
> > visibility support and enhance existing modifiers' support.
>
> I was thinking the very same thing after __construct() came up, but wasn=
=E2=80=99t
> sure how it should work. :)
>
> > Now what I mean by class visibility, it requires a better discussion on
> how
> > it could behave, since any other language relies on nested classes to
> > expose this support. Nevertheless, PHP's lack of Open/Close principle
> > support could be addressed easily. This is my POV on how it could behav=
e:
> >
> > - private classes: Can only be extended and instantiated inside of the
> same
> > namespace it sits. This is the similar to private-package support in
> Java.
> > - protected classes: I can't determine any similarity to any other
> language
> > in this one, but it could behave somehow like: can be extended and
> > instantiated anywhere within the root namespace.
> > - public classes: same as current PHP support
> >
> > What do you think about it?
>
> I think it=E2=80=99s a good idea, the problem is defining private and pro=
tected.
>
> I wonder if this is something autoloaders could handle? private classes
> might be visible only within the same file, while protected classes might
> be visible only to other files the autoloader can see.
>
> --
> Andrea Faulds
> http://ajf.me/
>
>
>
>
>


--=20
Guilherme Blanco
MSN: guilhermeblanco@hotmail.com
GTalk: guilhermeblanco
Toronto - ON/Canada

--089e0103de4e0f74ff05082843b6--