Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78936
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.181 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <546ADD8A.20400@gmail.com>
References: <CA+9eiLs+3CXmHcu0wsP76reFseWw=oFTKD_Svn20zCh=kzdMZg@mail.gmail.com>
	<CABBJUpcZ3XmdQN0v3FjM5+nFi0SKoQbGz0obtp2KkzO2kdsbmw@mail.gmail.com>
	<CA+9eiLuLv2NJono_k1+3d8Jg-CD9hR5ydvxszxO6eiJLUD48-g@mail.gmail.com>
	<C0CC2815-DE89-48EA-BDC2-1FE19A3AACE2@gmail.com>
	<CA+9eiLuWoj+kGd+XVxZ5i=iLe+TOjC75Sgnims-1kgbdgw-qMA@mail.gmail.com>
	<546ADD8A.20400@gmail.com>
Date: Tue, 18 Nov 2014 13:40:25 +0400
Message-ID: <CA+9eiLt8w9pv8D1vacBc=jFOjxdUmFSV7eR-5MBk-4fkKx0H-A@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: Xinchen Hui <laruence@gmail.com>, Xinchen Hui <xinchen.h@zend.com>, 
	Nikita Popov <nikita.ppv@gmail.com>, Anatol Belski <ab@php.net>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec52d57cb77eda505081ee2e6
Subject: Re: [PHP-DEV] Re: Use zend_string* for op_array->arg_info[].name and class_name
From: dmitry@zend.com (Dmitry Stogov)

--bcaec52d57cb77eda505081ee2e6
Content-Type: text/plain; charset=UTF-8

Of course, it would be great to always use zend_string, but only arg_info
duplication (without char -> zend_string) would add ~90KB on 32-bit system
and ~150KB on 64-bit system per process. So I expect 300-500KB wasted per
process.

Actually, only inheritance and reflection code was complicated by the patch
(not significantly).

Thanks. Dmitry.



On Tue, Nov 18, 2014 at 8:47 AM, Stanislav Malyshev <smalyshev@gmail.com>
wrote:

> Hi!
>
> >> we only need do it in master process, and mark as interned(with hash
> >> precalculated), no write will be happened, so thanks to COW on fork, we
> >> won't need lots of extra memory.
> >>
> >
> > It's not true for Windows.
> > On Linux we would copy arg_info from shared read-only segment into
> process
> > heap memory, then some blocks may be COW or not depended on luck.
>
> How bad would it be? Given that significantly simplifies the code, and
> does not require to check and write two branches each time we deal with
> arginfo, maybe it is worth to spend some memory (given that we only
> spend it once on init)?
>

--bcaec52d57cb77eda505081ee2e6--