Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78930
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABBJUpcZ3XmdQN0v3FjM5+nFi0SKoQbGz0obtp2KkzO2kdsbmw@mail.gmail.com>
References: <CA+9eiLs+3CXmHcu0wsP76reFseWw=oFTKD_Svn20zCh=kzdMZg@mail.gmail.com>
	<CABBJUpcZ3XmdQN0v3FjM5+nFi0SKoQbGz0obtp2KkzO2kdsbmw@mail.gmail.com>
Date: Tue, 18 Nov 2014 08:34:50 +0400
Message-ID: <CA+9eiLuLv2NJono_k1+3d8Jg-CD9hR5ydvxszxO6eiJLUD48-g@mail.gmail.com>
To: Xinchen Hui <xinchen.h@zend.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>, Anatol Belski <ab@php.net>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c22bf09fb29d05081a9d5b
Subject: Re: Use zend_string* for op_array->arg_info[].name and class_name
From: dmitry@zend.com (Dmitry Stogov)

--001a11c22bf09fb29d05081a9d5b
Content-Type: text/plain; charset=UTF-8

On Tue, Nov 18, 2014 at 6:01 AM, Xinchen Hui <xinchen.h@zend.com> wrote:

> Hey:
>
>
>
> On Mon, Nov 17, 2014 at 5:25 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> > Hi,
> >
> > Please review the patch
> https://gist.github.com/dstogov/47a39aff37f0a6441ea0
>
> I am not sure, why can't we build a zend_string arg->name  from char *
> while doing register internal functions?
>

We can, but it'll take significant amount of additional memory and then we
will have to free it on shutdown.

Thanks. Dmitry.


>
> then we can have the same zend_arg_info in runtime for both
> internal/user functions?
>
> thanks
> >
> > Thanks. Dmitry.
>
>
>
> --
> Xinchen Hui
> @Laruence
> http://www.laruence.com/
>

--001a11c22bf09fb29d05081a9d5b--