Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:78929 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 23619 invoked from network); 18 Nov 2014 03:01:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Nov 2014 03:01:50 -0000 Authentication-Results: pb1.pair.com smtp.mail=laruence@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=laruence@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.48 as permitted sender) X-PHP-List-Original-Sender: laruence@gmail.com X-Host-Fingerprint: 209.85.215.48 mail-la0-f48.google.com Received: from [209.85.215.48] ([209.85.215.48:56405] helo=mail-la0-f48.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 19/E4-06780-B96BA645 for ; Mon, 17 Nov 2014 22:01:48 -0500 Received: by mail-la0-f48.google.com with SMTP id s18so5436401lam.7 for ; Mon, 17 Nov 2014 19:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=Xx8P4KEZmfLQMAyVqSXNnihmLmDrqR2XSi/aYVHJvp4=; b=H55eUrwf9h7DsA3DL18hXm0Rc4/JwZwt0tN5Vd+bfxzr6QzQdG9MCWk3j22AtsQUCe lv0poAKfQs/6cVIWDUAEpbIso/PQCenWgBFIanvKVxjwJ/grDh1hcvWLfX6wJnuSWJUN OJm/6ysuy1jwgB1bp73CkZtR4VoWx9SuXd9PF3SzW3ffK9PYJloTPPvnS9+38c3tU0sI IWFQLuFSFnljjt7ym0+uD4ySCa9zbrQ+nSpkWTfuB6UamxHFYTD397Zjcs+re0q3Yruz Vr1ngnC8Y4fNEVXL+YpTsdzJMi50dv1OcubJgFNBTrxs+KMX+vjTfxwT71dTk9dw5G9g al7g== X-Received: by 10.112.45.228 with SMTP id q4mr32632066lbm.35.1416279703304; Mon, 17 Nov 2014 19:01:43 -0800 (PST) MIME-Version: 1.0 Sender: laruence@gmail.com Received: by 10.114.64.240 with HTTP; Mon, 17 Nov 2014 19:01:23 -0800 (PST) In-Reply-To: References: Date: Tue, 18 Nov 2014 11:01:23 +0800 X-Google-Sender-Auth: wC27hBaDV-sfP4Jtk8guRtjGVOA Message-ID: To: Dmitry Stogov Cc: Nikita Popov , Anatol Belski , PHP Internals Content-Type: text/plain; charset=UTF-8 Subject: Re: Use zend_string* for op_array->arg_info[].name and class_name From: xinchen.h@zend.com (Xinchen Hui) Hey: On Mon, Nov 17, 2014 at 5:25 PM, Dmitry Stogov wrote: > Hi, > > Please review the patch https://gist.github.com/dstogov/47a39aff37f0a6441ea0 I am not sure, why can't we build a zend_string arg->name from char * while doing register internal functions? then we can have the same zend_arg_info in runtime for both internal/user functions? thanks > > Thanks. Dmitry. -- Xinchen Hui @Laruence http://www.laruence.com/