Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78921
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain margaine.com from 209.85.213.180 cause and error)
MIME-Version: 1.0
In-Reply-To: <1416210170.27517.1.camel@localhost.localdomain>
References: <CABRjmp9d+LQTqUSu_-NKQVyAgMN5F85yzy92-xqUR8L+TNvXPA@mail.gmail.com>
 <1416210170.27517.1.camel@localhost.localdomain>
Date: Mon, 17 Nov 2014 09:00:17 +0100
Message-ID: <CABRjmp_d5siA8h3Vvgga1CtnQ+WsDYe0Kg6a6z9Pu-PDooJRjQ@mail.gmail.com>
To: Joe Watkins <pthreads@pthreads.org>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0149bb86c1b91b0508095ffe
Subject: Re: [PHP-DEV] SAPI refactoring
From: florian@margaine.com (Florian Margaine)

--089e0149bb86c1b91b0508095ffe
Content-Type: text/plain; charset=UTF-8

Hi Joe,

On Mon, Nov 17, 2014 at 8:42 AM, Joe Watkins <pthreads@pthreads.org> wrote:

> On Sat, 2014-11-15 at 11:16 +0100, Florian Margaine wrote:
> > Hi list,
> >
> > As of today, most of the SAPIs have a lot of code duplication with
> > regards to HTTP headers parsing/handling.
> >
> > I'm about to completely duplicate a function from one SAPI to the
> > other to add a feature to fpm (`getallheaders()`, see
> > https://github.com/php/php-src/pull/523), and I'd like to avoid that.
> >
> > Should I create a `sapi/main/` folder for common functions across the
> > SAPIs? Or should each SAPI remain completely independent from each
> > other, even if it means duplicating code?
> >
> > Regards,
> >
>
> Morning Florian,
>
>         There is already a place to put shared SAPI code.
>
>         main/SAPI.h
>         main/SAPI.c
>
>         There is also a SAPI_API decl that you will need to use.
>

Thanks!


>
> Cheers
> Joe
>
>

Cheers,
-- 
Florian Margaine

--089e0149bb86c1b91b0508095ffe--