Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78920
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain pthreads.org from 209.85.212.179 cause and error)
Message-ID: <1416210170.27517.1.camel@localhost.localdomain>
To: Florian Margaine <florian@margaine.com>
Cc: PHP Internals <internals@lists.php.net>
Date: Mon, 17 Nov 2014 07:42:50 +0000
In-Reply-To: <CABRjmp9d+LQTqUSu_-NKQVyAgMN5F85yzy92-xqUR8L+TNvXPA@mail.gmail.com>
References: 
	<CABRjmp9d+LQTqUSu_-NKQVyAgMN5F85yzy92-xqUR8L+TNvXPA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] SAPI refactoring
From: pthreads@pthreads.org (Joe Watkins)

On Sat, 2014-11-15 at 11:16 +0100, Florian Margaine wrote:
> Hi list,
> 
> As of today, most of the SAPIs have a lot of code duplication with
> regards to HTTP headers parsing/handling.
> 
> I'm about to completely duplicate a function from one SAPI to the
> other to add a feature to fpm (`getallheaders()`, see
> https://github.com/php/php-src/pull/523), and I'd like to avoid that.
> 
> Should I create a `sapi/main/` folder for common functions across the
> SAPIs? Or should each SAPI remain completely independent from each
> other, even if it means duplicating code?
> 
> Regards,
> 

Morning Florian,

	There is already a place to put shared SAPI code.

	main/SAPI.h
	main/SAPI.c

	There is also a SAPI_API decl that you will need to use.

Cheers
Joe