Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:78916 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 5711 invoked from network); 15 Nov 2014 10:16:35 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Nov 2014 10:16:35 -0000 Authentication-Results: pb1.pair.com smtp.mail=florian@margaine.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=florian@margaine.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain margaine.com from 209.85.213.182 cause and error) X-PHP-List-Original-Sender: florian@margaine.com X-Host-Fingerprint: 209.85.213.182 mail-ig0-f182.google.com Received: from [209.85.213.182] ([209.85.213.182:53785] helo=mail-ig0-f182.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 25/70-00515-20827645 for ; Sat, 15 Nov 2014 05:16:34 -0500 Received: by mail-ig0-f182.google.com with SMTP id hn18so2855721igb.3 for ; Sat, 15 Nov 2014 02:16:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-type; bh=ELQR+lAPFUIRSgeSAmqNEgf6JuJ3DSfe/2GbigzPSvM=; b=l5DK91N8A1GstIi97ZWXTe1NEWFaicQ2k6jlD2E/MLwEjQtlAvsprPn5gHCHlUnkpJ t8WNa3Fl+51i1o7lc9lJsQ6V8t18GylzCoS2O34jEC7aR8Zwq42nnbnPTxF+pg13wzdy OJ7Al0qeo+a7MK/g06lVSN9AByaFfTDszhDJABbf7pd8jwIwGMCSq7ikvBI6ugbh1Hic aOYFstOdtA08i05elVGH8t9Wsx76/uFXlhyg1nopJe20uOtz61IWTH09NV7H2m/mKuAA WRCgMGTbT1/rRr6ygDH2CSzPPIpwqL88eKFDPAmFhLDMh8s7hZysEEuzgtCKxigulg5j 6LLg== X-Gm-Message-State: ALoCoQmJU/XANN1HfudaNCA9+PcxosaCj3J50pDmiMeeajJ4R+EHWK5xScd9isTtlKuuuPjgFo/u X-Received: by 10.107.34.9 with SMTP id i9mr15709044ioi.33.1416046591712; Sat, 15 Nov 2014 02:16:31 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.31.149 with HTTP; Sat, 15 Nov 2014 02:16:11 -0800 (PST) X-Originating-IP: [93.8.60.115] Date: Sat, 15 Nov 2014 11:16:11 +0100 Message-ID: To: PHP Internals Content-Type: multipart/alternative; boundary=001a1140ed5015bd1e0507e30a72 Subject: SAPI refactoring From: florian@margaine.com (Florian Margaine) --001a1140ed5015bd1e0507e30a72 Content-Type: text/plain; charset=UTF-8 Hi list, As of today, most of the SAPIs have a lot of code duplication with regards to HTTP headers parsing/handling. I'm about to completely duplicate a function from one SAPI to the other to add a feature to fpm (`getallheaders()`, see https://github.com/php/php-src/pull/523), and I'd like to avoid that. Should I create a `sapi/main/` folder for common functions across the SAPIs? Or should each SAPI remain completely independent from each other, even if it means duplicating code? Regards, -- Florian Margaine --001a1140ed5015bd1e0507e30a72--