Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78894
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain tutteli.ch designates 80.74.154.78 as permitted sender)
To: "'Chris Wright'" <cw@daverandom.com>,
	=?utf-8?Q?'Johannes_Schl=C3=BCter'?= <johannes@schlueters.de>
Cc: "'Adam Harvey'" <aharvey@php.net>,
	"'PHP Internals'" <internals@lists.php.net>
References: <000201cff3b2$37615e50$a6241af0$@tutteli.ch>	<001101cffda8$9f56e980$de04bc80$@tutteli.ch>	<CADajX4B-mFu=ETAkHGYD4quDu+Ddegi8gPkHiX5Lmqv9Sr7daA@mail.gmail.com>	<001a01cffebf$76f5c2a0$64e147e0$@tutteli.ch>	<1415878147.11005.1.camel@kuechenschabe> <CAGAGxbYxD91rPT15_PnVMwP8yoS1YfFyncfiBDQirjjX1EARyA@mail.gmail.com>
In-Reply-To: <CAGAGxbYxD91rPT15_PnVMwP8yoS1YfFyncfiBDQirjjX1EARyA@mail.gmail.com>
Date: Thu, 13 Nov 2014 13:40:08 +0100
Message-ID: <001c01cfff3e$f6344670$e29cd350$@tutteli.ch>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQIPPXtbPZBTwayAd3/waoyNKhChzAEtjs3+AdXjotIBhDhuxANAm77fAhwlQfabkN0bYA==
Content-Language: de-ch
Subject: AW: AW: [PHP-DEV] forbid use declaration outside of a namespace in PHP 7
From: php@tutteli.ch ("Robert Stoll")

> -----Urspr=C3=BCngliche Nachricht-----
> Von: are.you.winning@gmail.com [mailto:are.you.winning@gmail.com] Im =
Auftrag von Chris Wright
> Gesendet: Donnerstag, 13. November 2014 13:13
> An: Johannes Schl=C3=BCter
> Cc: Robert Stoll; Adam Harvey; PHP Internals
> Betreff: Re: AW: [PHP-DEV] forbid use declaration outside of a =
namespace in PHP 7
>=20
> On 13 November 2014 11:29, Johannes Schl=C3=BCter =
<johannes@schlueters.de> wrote:
>=20
> > On Wed, 2014-11-12 at 22:27 +0100, Robert Stoll wrote:
> >
> > > That's still perfectly fine because in your code the use statement
> > > is
> > not outside of a namespace, it is implicitly in the default =
namespace.
> > > I am talking about the two following scenarios:
> > >
> > > use \Exception;
> > > namespace test;
> > >
> > > $e =3D new Exception(); //would fails because test\Exception is
> > > unknown ->
> > use was defined outside the namespace
> > >
> > >
> > > Or
> > > namespace a{
> > > }
> > >
> > > use some\UseDeclaration\which\is\outside\of\AnyNamespace as =
Useless;
> > > //
> > sorry for begin biased ^^
> > >
> > > namespace test{
> > > }
> >
> > If I get it rigth this might break code by people who, for whatever
> > reason, combine multiple PHP files into a single one. (cat *.php >
> > full.php && php full.php)
> >
> >
> This would only break if the individual files were already invalid. =
Files with namespace Name; style ns declarations couldn't
> be joined together in this way anyway, and files using namespace Name =
{ ... } style declarations with use imports outside
> the block would be invalid on their own, concatenating them wouldn't =
break (or fix) this situation. Unless I missed
> something?

[Robert Stoll]=20
I share Chris' statement. Combining multiple files would only work if =
they all use namespace blocks or if they do not use any namespaces at =
all (and thus are implicitly in the default namespace).

>=20
> I must say actually that while I think a use declaration outside a =
block-style namespace should be invalid, I'm about 50/50 on
> whether something like this should be invalid:
>=20
> <?php
>=20
> use \Foo;
> namespace Bar;
>=20
> The current behaviour is certainly wrong, but in this case it might be =
good to treat it as if the use declaration was after the
> ns declaration, rather than making it invalid (I haven't looked at how =
easy this would be to accomplish, though).
>=20

[Robert Stoll]=20
I think it would be wrong to start to do such auto-fixes. Syntax which =
is wrong should emit a fatal error IMO (assuming we would disallow =
use-statement outside of a namespace). In this case the user has to move =
the statement down a few lines and it works again. Better than =
auto-fixing which might introduce unintended bugs.

>=20
> johannes
> >
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List To unsubscribe,
> > visit: http://www.php.net/unsub.php
> >
> >