Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78893
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain tutteli.ch designates 80.74.154.78 as permitted sender)
To: "'Rowan Collins'" <rowan.collins@gmail.com>,
	<internals@lists.php.net>
References: <000201cff3b2$37615e50$a6241af0$@tutteli.ch> <001101cffda8$9f56e980$de04bc80$@tutteli.ch> <CADajX4B-mFu=ETAkHGYD4quDu+Ddegi8gPkHiX5Lmqv9Sr7daA@mail.gmail.com> <001a01cffebf$76f5c2a0$64e147e0$@tutteli.ch> <54648E94.5060802@gmail.com>
In-Reply-To: <54648E94.5060802@gmail.com>
Date: Thu, 13 Nov 2014 13:30:49 +0100
Message-ID: <001b01cfff3d$a8fc7900$faf56b00$@tutteli.ch>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQIPPXtbPZBTwayAd3/waoyNKhChzAEtjs3+AdXjotIBhDhuxACRyOZdm7cxEDA=
Content-Language: de-ch
Subject: AW: AW: [PHP-DEV] forbid use declaration outside of a namespace in PHP 7
From: php@tutteli.ch ("Robert Stoll")

> -----Urspr=C3=BCngliche Nachricht-----
> Von: Rowan Collins [mailto:rowan.collins@gmail.com]
> Gesendet: Donnerstag, 13. November 2014 11:57
> An: internals@lists.php.net
> Betreff: Re: AW: [PHP-DEV] forbid use declaration outside of a =
namespace in PHP 7
>=20
> Robert Stoll wrote on 12/11/2014 21:27:
>=20
> > That's still perfectly fine because in your code the use statement =
is not outside of a namespace, it is implicitly in the
> default namespace.
>=20
> Surely if that's true of Adam's example, it's true of yours as well?

[Robert Stoll]=20
The difference is that I have specified a namespace and thus code =
outside of that namespace is no longer implicitly in the default =
namespace.

> > namespace a{
> > }
> >
> > use some\UseDeclaration\which\is\outside\of\AnyNamespace as Useless;
> > // sorry for begin biased ^^
> >
> > namespace test{
> > }
>=20
> This scenario looks identical to Adam's to me, unless you propose to =
look at the entirety of the file to detect if there is
> something other than a use statement in the default namespace.

[Robert Stoll]=20
Same applies here, my use statement is outside of a namespace Adam's =
isn't.

> For that matter, what about this:
>=20
> use GuzzleHttp\Client;
>=20
> include __DIR__.'/vendor/autoload.php';
>=20
> $client =3D new Client;
> // $client is a GuzzleHttp\Client object
>=20
> namespace Foo;
> $client =3D new Client;
> // $client is a Foo\Client object
>=20
> Certainly this code is not *sensible*, but it does have a meaningful =
behaviour, which derives directly from the previous
> examples and documented uses of the namespace keyword. I'm not sure =
how you'd distinguish between the various
> combinations here.
>=20
> Regards,
> --
> Rowan Collins
> [IMSoP]
>=20

[Robert Stoll]
I haven't tested it I am pretty sure this script would fail since =
$client =3D new Client is outside of a namespace - an error message =
something like "namespace must be the first statement" would show up.
If I rewrite your code to the following:

namespace{
  use GuzzleHttp\Client;
=20
  include __DIR__.'/vendor/autoload.php';
=20
  $client =3D new Client;
  // $client is a GuzzleHttp\Client object
 =20
namespace Foo{
  $client =3D new Client;
  // $client is a Foo\Client object
}

Then it would make sense (use statement is inside a namespace).