Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78892
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.176 as permitted sender)
MIME-Version: 1.0
Sender: are.you.winning@gmail.com
In-Reply-To: <1415878147.11005.1.camel@kuechenschabe>
References: <000201cff3b2$37615e50$a6241af0$@tutteli.ch>
	<001101cffda8$9f56e980$de04bc80$@tutteli.ch>
	<CADajX4B-mFu=ETAkHGYD4quDu+Ddegi8gPkHiX5Lmqv9Sr7daA@mail.gmail.com>
	<001a01cffebf$76f5c2a0$64e147e0$@tutteli.ch>
	<1415878147.11005.1.camel@kuechenschabe>
Date: Thu, 13 Nov 2014 12:13:03 +0000
Message-ID: <CAGAGxbYxD91rPT15_PnVMwP8yoS1YfFyncfiBDQirjjX1EARyA@mail.gmail.com>
To: =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>
Cc: Robert Stoll <php@tutteli.ch>, Adam Harvey <aharvey@php.net>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7ba976322557370507bc6f02
Subject: Re: AW: [PHP-DEV] forbid use declaration outside of a namespace in
 PHP 7
From: cw@daverandom.com (Chris Wright)

--047d7ba976322557370507bc6f02
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 13 November 2014 11:29, Johannes Schl=C3=BCter <johannes@schlueters.de> =
wrote:

> On Wed, 2014-11-12 at 22:27 +0100, Robert Stoll wrote:
>
> > That's still perfectly fine because in your code the use statement is
> not outside of a namespace, it is implicitly in the default namespace.
> > I am talking about the two following scenarios:
> >
> > use \Exception;
> > namespace test;
> >
> > $e =3D new Exception(); //would fails because test\Exception is unknown=
 ->
> use was defined outside the namespace
> >
> >
> > Or
> > namespace a{
> > }
> >
> > use some\UseDeclaration\which\is\outside\of\AnyNamespace as Useless;  /=
/
> sorry for begin biased ^^
> >
> > namespace test{
> > }
>
> If I get it rigth this might break code by people who, for whatever
> reason, combine multiple PHP files into a single one. (cat *.php >
> full.php && php full.php)
>
>
This would only break if the individual files were already invalid. Files
with namespace Name; style ns declarations couldn't be joined together in
this way anyway, and files using namespace Name { ... } style declarations
with use imports outside the block would be invalid on their own,
concatenating them wouldn't break (or fix) this situation. Unless I missed
something?

I must say actually that while I think a use declaration outside a
block-style namespace should be invalid, I'm about 50/50 on whether
something like this should be invalid:

<?php

use \Foo;
namespace Bar;

The current behaviour is certainly wrong, but in this case it might be good
to treat it as if the use declaration was after the ns declaration, rather
than making it invalid (I haven't looked at how easy this would be to
accomplish, though).


johannes
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--047d7ba976322557370507bc6f02--