Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:78886 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 40027 invoked from network); 12 Nov 2014 18:10:41 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Nov 2014 18:10:41 -0000 Authentication-Results: pb1.pair.com smtp.mail=dunglas@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=dunglas@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.49 as permitted sender) X-PHP-List-Original-Sender: dunglas@gmail.com X-Host-Fingerprint: 74.125.82.49 mail-wg0-f49.google.com Received: from [74.125.82.49] ([74.125.82.49:36654] helo=mail-wg0-f49.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 26/A1-30822-0A2A3645 for ; Wed, 12 Nov 2014 13:10:40 -0500 Received: by mail-wg0-f49.google.com with SMTP id x13so14964777wgg.8 for ; Wed, 12 Nov 2014 10:10:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=wRGMGBw8gBIkp3/l3C3Z/rg00PkN/zK1v19IHhcFT/k=; b=Z+TMU04ZH8lt41Oac+4oTnZdIGKGaCI/HtLPP/A84Jr/LN8ehKUcnbLEKdyTSeaMAF mNnj49jfrDtX9OeX0H/m3bqmGGiCPzPWPg7wz+bVlwc8yub2exrWl6oZNABVi1rB1gEM OuiU6e2G7H5+s4ja7dqQDBRhxlcKVUhjhI6OSvKhBz3YeDT8+OnNm2wVHXrB10Vo0Nkw 2ZnHo/ai8yY55+/SAoNDFXs+HV4gD1pQsHmybvYHS8TKKr/EFRuESWQleoWsTZIWr3M9 4BGQrXmLF9Xy54tzUTv7SiQQOaQ6nc78UyNKDyBG2JvDcm10AgmFFrgmt9EKFmsXxkBF eCIA== X-Received: by 10.180.9.33 with SMTP id w1mr8275668wia.22.1415815837206; Wed, 12 Nov 2014 10:10:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.194.40.68 with HTTP; Wed, 12 Nov 2014 10:10:16 -0800 (PST) In-Reply-To: References: Date: Wed, 12 Nov 2014 19:10:16 +0100 Message-ID: To: Yasuo Ohgaki Cc: Sanford Whiteman , Sean Coates , Andrey Andreev , Daniel Ribeiro , PHP Internals Content-Type: multipart/alternative; boundary=001a11c2406c0b4e250507ad50e9 Subject: Re: [PHP-DEV] Better RFC conformance for FILTER_VALIDATE_URL From: dunglas@gmail.com (=?UTF-8?Q?K=C3=A9vin_Dunglas?=) --001a11c2406c0b4e250507ad50e9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Yasuo, I've not changed (and even read) the email validator. I'll take a look at it. 2014-11-12 10:41 GMT+01:00 Yasuo Ohgaki : > Hi Kevin, > > On Wed, Nov 12, 2014 at 4:09 PM, K=C3=A9vin Dunglas w= rote: > >> I'll change my PR according to the RFC I've quoted earlier: >> - check for valid characters (excluding underscore) only when >> FILTER_FLAG_HOSTNAME is set >> - allow any character but check lengths by default >> - use FILTER_FLAG_HOSTNAME to validate URLs >> >> What do you think about that? >> > > I haven't read diff closely, but it seems ok to me. > How email domain is checked? I cannot see changes for it from the diff. > > Validating host correctly is difficult, I would like to have your PR. > > Regards, > > -- > Yasuo Ohgaki > yohgaki@ohgaki.net > --=20 K=C3=A9vin Dunglas http://dunglas.fr --001a11c2406c0b4e250507ad50e9--