Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:78879 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 4289 invoked from network); 12 Nov 2014 09:41:57 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Nov 2014 09:41:57 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.182 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.223.182 mail-ie0-f182.google.com Received: from [209.85.223.182] ([209.85.223.182:34384] helo=mail-ie0-f182.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F0/64-02954-46B23645 for ; Wed, 12 Nov 2014 04:41:57 -0500 Received: by mail-ie0-f182.google.com with SMTP id rd18so13193074iec.27 for ; Wed, 12 Nov 2014 01:41:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=vZC6e9m4z9a7r8tJmDsMeExVe385a8Zf25lDftCVe8Y=; b=kq3ufL4zTuCn9+giYGVzukJNLRQBet9DK4a9QVKQAN+heM8KVCeAXfRtPcBEfsDvXX dYOIZX/hs7cwB3rHCAkCwupt7btH5GoMbTW1fA3ani4se4edTeQyeWUBhK7RIVjWUzJh 7gBn83e4RgwMGBjOC0do2e/k2nwMlrFP4CWtE/hl33qt8TyjLfgup5E9JNMEyu7n9N+z 5J/yiPcUDp6g5ultnZBfoy2rTsowMAc+EYxHd3j7iC+YzUnEqN2Mm3DxNxmSX7ok+mB1 jbjsQmrTp1p8NJE3QtRudTVaY51fSLoPz+WZk+fmC71MhcB142ChnbXpYO5ZW1VIhHc8 klHQ== X-Received: by 10.107.41.199 with SMTP id p190mr48310144iop.10.1415785314251; Wed, 12 Nov 2014 01:41:54 -0800 (PST) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.107.132.216 with HTTP; Wed, 12 Nov 2014 01:41:14 -0800 (PST) In-Reply-To: References: Date: Wed, 12 Nov 2014 18:41:14 +0900 X-Google-Sender-Auth: 66vAUoeVrnoJgYohOIONgXjEjfw Message-ID: To: =?UTF-8?Q?K=C3=A9vin_Dunglas?= Cc: Sanford Whiteman , Sean Coates , Andrey Andreev , Daniel Ribeiro , PHP Internals Content-Type: multipart/alternative; boundary=001a1141d956bbfbc10507a6341e Subject: Re: [PHP-DEV] Better RFC conformance for FILTER_VALIDATE_URL From: yohgaki@ohgaki.net (Yasuo Ohgaki) --001a1141d956bbfbc10507a6341e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Kevin, On Wed, Nov 12, 2014 at 4:09 PM, K=C3=A9vin Dunglas wro= te: > I'll change my PR according to the RFC I've quoted earlier: > - check for valid characters (excluding underscore) only when > FILTER_FLAG_HOSTNAME is set > - allow any character but check lengths by default > - use FILTER_FLAG_HOSTNAME to validate URLs > > What do you think about that? > I haven't read diff closely, but it seems ok to me. How email domain is checked? I cannot see changes for it from the diff. Validating host correctly is difficult, I would like to have your PR. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --001a1141d956bbfbc10507a6341e--