Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78818
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <545B7871.2010502@gmx.de>
References: <CABRjmp-oqEVtX-igQWsr-JkFmitqxn4YsyJ=mnzyHCN9Kj7akA@mail.gmail.com>
	<CAH-PCH62GAecxC00aHgzgskG8zk58z1LBE1uBv81xtj6hRiy5w@mail.gmail.com>
	<3E2593DC-5755-48A6-8802-6F2FB3625778@ajf.me>
	<CAEZPtU5bdrgX3yfNZhPsWqrU6d5fw=vX78-iW=gx1jUJoeF8YA@mail.gmail.com>
	<04723EAD-4C8E-41C2-BE81-4989882A0C69@ajf.me>
	<545B26BB.9020406@lsces.co.uk>
	<545B589A.4010606@gmx.de>
	<CAH-PCH56mVMk0S2JzVOM9y7Jbu2mdQEss6E+NDBZne_YSTFWnA@mail.gmail.com>
	<545B7871.2010502@gmx.de>
Date: Thu, 6 Nov 2014 15:22:36 +0100
Message-ID: <CAH-PCH54+xOPYcpW8MPB45mjKSfbRMpgYbj=wPwBnP7_ymYdCQ@mail.gmail.com>
To: Christoph Becker <cmbecker69@gmx.de>
Cc: Lester Caine <lester@lsces.co.uk>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113d769a9121af0507316dd7
Subject: Re: [PHP-DEV] Thresholds of backwards compatibility breaks
From: tyra3l@gmail.com (Ferenc Kovacs)

--001a113d769a9121af0507316dd7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 6, 2014 at 2:32 PM, Christoph Becker <cmbecker69@gmx.de> wrote:

> Ferenc Kovacs wrote:
>
> > On Thu, Nov 6, 2014 at 12:16 PM, Christoph Becker <cmbecker69@gmx.de>
> wrote:
> >
> >> Lester Caine wrote:
> >>
> >>> Yes it is only a number, but a lot more problematic changes WERE push=
ed
> >>> through across those three versions which would have been much safer
> >>> handled by removing e_strict from PHP5.4 rather than trying to live
> with
> >>> both versions of PHP.
> >>
> >> I don't see a problem with regard to E_STRICT.  If your code is not ye=
t
> >> strict compliant, simply turn it off for error_reporting:
> >>
> >>   error_reporting =3D E_ALL & ~E_STRICT
> >>
> >> --
> >> Christoph M. Becker
> >
> > for the record, see https://bugs.php.net/bug.php?id=3D65322 and the iss=
ued
> > linked from that.
> > turned out that we had a bug, which prevented the autoload calls inside
> an
> > error handler call when the original error was a compile time one.
> > we have some compile time strict errors about abstract classes which
> could
> > have triggered hard-to-debug fatal errors for people(with custom error
> > handlers which depend on dynamic auto loading) when we made E_STRICT pa=
rt
> > of E_ALL in 5.4.
>
> Thanks for pointing this out -- I have not been aware of the issue.  Of
> course, having had this bug for such a long time is unfortunate, but it
> seems to me a viable userland workaround for not yet "strict" code to
> support affected PHP versions would be to pass an appropriate
> $error_types argument to the set_error_handler call, e.g.
>
>   set_error_handler('my_error_handler', E_ALL & ~E_STRICT);
>
> --
> Christoph M. Becker
>
>
the bug is already fixed by Nikita, I only brought it up, as an example
that migrating to 5.4 and the fact that we included E_STRICT to E_ALL could
indeed cause fatal errors for some application.
ofc after you realize the issue, there were a couple of ways to mitigate it
(the easiest is to change your php.ini to remove E_STRICT from
error_reporting or changing your error handler to not care about these kind
of errors or to not depend on the availability of your autoloader).


--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--001a113d769a9121af0507316dd7--