Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:78795
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.218.51 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXairu-1-_NejDPpH0eMoyX1Ay_Pz03L946i5QGtqakA8A@mail.gmail.com>
References: <CAAg69r=3wxiPyE5_hKOf2rY49=60a-BihsG24g9nZVrUs1iOTw@mail.gmail.com>
	<CAGa2bXaG1wLZfJfgzwZiSNC+DE5-ZPAaOd2mrFSvLUYqiyJzYQ@mail.gmail.com>
	<CAGa2bXairu-1-_NejDPpH0eMoyX1Ay_Pz03L946i5QGtqakA8A@mail.gmail.com>
Date: Thu, 6 Nov 2014 10:42:33 +0200
Message-ID: <CAPhkiZweUB94K0HgAKtZ+kyff=bJA==8xLPHq8keL=0mSAKomA@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Damian Wadley <php@requinix.net>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Lazy writing in the session, session-lock-ini, and bug #68331
From: narf@devilix.net (Andrey Andreev)

Hi,

On Thu, Nov 6, 2014 at 4:02 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> HI all,
>
> On Thu, Nov 6, 2014 at 6:30 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>
>> On Wed, Nov 5, 2014 at 10:54 AM, Damian Wadley <php@requinix.net> wrote:
>>
>>> Apparently this caused
>>> problems for some people as they made 68331 a few days ago.
>>>
>>
>> Just a quick note for this. The user would like to access session
>> data(session handler)
>> regardless of data modification. I suppose it could be solved if session
>> has user space
>> "update" handler as I suggested originally.
>>
>> Alternatively, session_write_close()/session_commit() may be changed, so
>> that it
>> is called unconditionally during shutdown. I have to read the code to be
>> sure if this is possible.
>>
>> BTW, anyone know the reason why the user need to call
>> session_write_close()/session_commit()
>> unconditionally? Accounting, perhaps?
>>
>
> The issue user has reported could be solved easily by calling write API
> during shutdown, IIRC.
> An explicit flag for this might be needed.

There already is such explicit flag in PHP 5.4's OOP version of
session_set_save_handler().
The linked test script in the bug report also explicitly registers
session_write_close() as a shutdown function.

The problem isn't that there's no call, it's that _the call itself is ignored_.


Cheers,
Andrey.